Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core #224

Merged
merged 129 commits into from
Oct 29, 2017
Merged

.NET Core #224

merged 129 commits into from
Oct 29, 2017

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Oct 4, 2017

fix #231

new fsproj are added in parallel to current, with some ifdef to disable unsupported feature/api changes

Some limitations:

  • no TP (not supported by FCS)
  • old fsproj require mono/.net installed
  • fsx require mono/.net installed

NOTES:

  • fsac.core .net standard version use F# 4.1 and the new Result type instead of custom FSAC Result type

TODO:

MAYBE (mean probably another PR):

  • add net45 tfm, so like now but with new sdk
  • upgrade suave to v2 also in net45

Example: Ionide running FSAC .net core, during a debugging session from another vscode

fsac_netcore

@enricosada
Copy link
Contributor Author

@Krzysztof-Cieslak on .net core fsac (on travis, on windows works), i get these test failure (ref log)

-  "Kind": "errors",
-  "Data": {
-    "File": "<absolute path removed>/FsAutoComplete.IntegrationTests/Colorizations/Script.fsx",
-    "Errors": []
-  }
+  "Kind": "info",
+  "Data": "Request cancelled"

pratically lots and lots of request get cancelled.

Any hint? is the recent cancellation PR?

@enricosada
Copy link
Contributor Author

added fsprojects/Paket#2868 to track the paket include script issue

enricosada added a commit to enricosada/ionide-vscode-fsharp that referenced this pull request Oct 27, 2017
…uild tools version 4 is not installed

like in appveyor VS2017
…4.8 (xbuild vs msbuild)

error after at second test:

Running fsi 'fsharpi --define:FSAC_TEST_HTTP --define:FSAC_TEST_EXE_NETCORE /home/travis/build/fsharp/FsAutoComplete/test/FsAutoComplete.IntegrationTests/DotNetCore/NotRestoredRunner.fsx' (from dir '/home/travis/build/fsharp/FsAutoComplete/test/FsAutoComplete.IntegrationTests/DotNetCore')
fsharpi --define:FSAC_TEST_HTTP --define:FSAC_TEST_EXE_NETCORE /home/travis/build/fsharp/FsAutoComplete/test/FsAutoComplete.IntegrationTests/DotNetCore/NotRestoredRunner.fsx
Server crashing error - Address already in use
    at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, String callerName)
   at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
   at System.Net.Sockets.Socket.Bind(EndPoint localEP)
   at Suave.Tcp.runServer@148-3.Invoke(Unit unitVar0)
   at Suave.Tcp.run@85[a](FSharpFunc`2 f, UInt16 _arg1)
   at Suave.Tcp.run@85[a](FSharpFunc`2 f, UInt16 _arg1)
   at Suave.Tcp.runServer@143-2.Invoke(Socket _arg1)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@839.Invoke(AsyncParams`1 args)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.FSharp.Control.AsyncBuilderImpl.commit[a](AsyncImplResult`1 res)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronouslyInCurrentThread[a](CancellationToken token, FSharpAsync`1 computation)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronously[a](CancellationToken token, FSharpAsync`1 computation, FSharpOption`1 timeout)
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken)
   at Suave.Web.startWebServer(SuaveConfig config, FSharpFunc`2 webpart)
   at FsAutoComplete.Suave.start(Commands commands, ParseResults`1 args) in /home/travis/build/fsharp/FsAutoComplete/src/FsAutoComplete/FsAutoComplete.Suave.fs:line 175
   at FsAutoComplete.Program.entry(String[] args) in /home/travis/build/fsharp/FsAutoComplete/src/FsAutoComplete/Program.fs:line 43
@enricosada enricosada changed the title [WIP] .NET Core .NET Core Oct 29, 2017
@enricosada enricosada merged commit 6ee483f into ionide:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

.NET Core based FSAC
1 participant