Fixing fsac stalls #104
Merged
Fixing fsac stalls #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://github.com/ionide/proj-info/pull/101/files\#r588779221 I said I didn't see a reason to exit early. Well turns of FSAC relies on this behavior. This backs out that change and puts checks around reloads instead
|
Testing this locally on my FSAC test-enhancements branch before merging. |
|
The thing that broke FSAC was the WorkspaceLoad events no longer being fired. This stalled out the listeners in our tests, which wait for the |
|
Looking great to me 👍. Going to merge and trigger a new release. I'm going to unlist 0.49 and 0.50 once FSAC has been merged with these changes, as those versions had this bug in them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/ionide/proj-info/pull/101/files\#r588779221 I said I didn't see a reason to exit early. Well turns of FSAC relies on this behavior. This backs out that change and puts checks around reloads instead. Also I clean up some variable names I forgot to finish out on another PR.