Go 1.21 touchups #160
Merged
Go 1.21 touchups #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65278
requested review from
avorima,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
mcbenjemaa
reviewed
Apr 2, 2024
wikkyk
approved these changes
Apr 3, 2024
|
|
The failing e2e is a false negative due to broken cleanup action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The test harness started failing on my end. This is because setup-envtest now depends on golang 1.22. At the moment I get segfaults when testing with golang 1.22.
While at it, I've also fixed documentation and docker build.
Testing performed:
Docker image built.
Test harness now runs again with golang 1.21