Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): allow for node overprovisioning #47

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

pborn-ionos
Copy link
Contributor

Basic attempt to implement #37.

  • ProxmoxCluster.spec.NodeMemoryAdjustment=300 allows to (theoretically) allocate 300% of a host's memory for VMs
  • ProxmoxCluster.spec.NodeMemoryAdjustment=95 allows to limit memory allocation to 95% of a host's memory
  • ProxmoxCluster.spec.NodeMemoryAdjustment=0 entirely disables scheduling memory constraints

Default value is 100 (= entirety of host's memory and current behaviour).

@pborn-ionos pborn-ionos force-pushed the feat/scheduler/overprovisioning-2 branch 4 times, most recently from 741ea12 to 104ffea Compare December 21, 2023 14:47
Copy link
Collaborator

@avorima avorima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. just have some remarks about user-facing comments

api/v1alpha1/proxmoxcluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/proxmoxcluster_types.go Show resolved Hide resolved
@pborn-ionos pborn-ionos force-pushed the feat/scheduler/overprovisioning-2 branch 2 times, most recently from cb6da0b to 91884e8 Compare December 21, 2023 15:28
Copy link
Collaborator

@avorima avorima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pborn-ionos pborn-ionos enabled auto-merge (squash) December 21, 2023 15:47
`ProxmoxCluster.spec.SchedulerHints.MemoryAdjustment=300` allows to (theoretically) allocate 300% of a host's memory for VMs (use with caution - enabling memory ballooning highly recommended)
`ProxmoxCluster.spec.SchedulerHints.MemoryAdjustment=95` allows to limit memory allocation to 95% of a host's memory
`ProxmoxCluster.spec.SchedulerHints.MemoryAdjustment=0` entirely disables scheduling memory constraints
@pborn-ionos pborn-ionos force-pushed the feat/scheduler/overprovisioning-2 branch from 91884e8 to 2769ccd Compare December 21, 2023 15:47
@pborn-ionos pborn-ionos merged commit ccbae16 into main Dec 21, 2023
9 checks passed
@pborn-ionos pborn-ionos deleted the feat/scheduler/overprovisioning-2 branch December 21, 2023 15:49
pborn-ionos added a commit that referenced this pull request Dec 22, 2023
pborn-ionos added a commit that referenced this pull request Dec 22, 2023
65278 pushed a commit that referenced this pull request Jan 17, 2024
* Bump docker/build-push-action from 4.1.1 to 5.0.0

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.1.1 to 5.0.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v4.1.1...v5.0.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix license headers

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mario Valderrama <mario.valderrama@ionos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants