Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix issue 86 #88

Merged
merged 3 commits into from Oct 17, 2022
Merged

Attempt to fix issue 86 #88

merged 3 commits into from Oct 17, 2022

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 17, 2022

@kwilcox I believe we were relying on a bug and passing an empty y to CubicSpline should return a ValuError but instead we just moved the iteration forward. This PR passes zeroes to ensure we have finite elements to start the iteration.

@kwilcox
Copy link
Member

kwilcox commented Oct 17, 2022

Could we raise a ValueError instead of returning a zeroed out array? That is what the calling function __get_daily_interp_subset expects? Raising a ValueError results in the same outcome.

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 17, 2022

Could we raise a ValueError instead of returning a zeroed out array? That is what the calling function __get_daily_interp_subset expects? Raising a ValueError results in the same outcome.

That is better. Working on it...

PS: That should probably be in SciPy.

@kwilcox kwilcox merged commit 5439fda into ioos:main Oct 17, 2022
@ocefpaf ocefpaf deleted the fix_86 branch October 17, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants