Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug or intended change of exit code for ios-deploy -c #80

Closed
zarko-tg opened this issue Nov 14, 2014 · 9 comments
Closed

Bug or intended change of exit code for ios-deploy -c #80

zarko-tg opened this issue Nov 14, 2014 · 9 comments
Labels

Comments

@zarko-tg
Copy link

Scenario: iPhone is not connected via USB to Mac. No other devices or simulators are connected / running.

With 1.2.0:
$ ios-deploy -c --timeout 2
[....] Waiting up to 2 seconds for iOS device to be connected
[....] Timed out waiting for device.
$ echo $?
253

With latest (1.3.0):
$ ios-deploy -c --timeout 2
[....] Waiting up to 2 seconds for iOS device to be connected
[....] No more devices found.
$ echo $?
0

This change breaks a script that depends on checking the exit code.
How would one proceed to resolve this ( and not resort to manual parsing of the output )?

@shazron
Copy link

shazron commented Nov 14, 2014

Seems to me a regression - I'll test and put out a patch release soon. Only a successful connection should be zero

@shazron
Copy link

shazron commented Nov 14, 2014

1.3.1 published.

@zarko-tg
Copy link
Author

Curly brackets are programmer's best friend ;)
Thanks for the prompt action.

@shazron
Copy link

shazron commented Nov 17, 2014

See #11 latest comments. Flaw in the patch.

@shazron
Copy link

shazron commented Nov 17, 2014

Also --debug needs to be turned on, if not you'll get a seg fault. iso-deploy will add it implicitly.

@shazron
Copy link

shazron commented Nov 17, 2014

1.3.2 published to fix 1.3.1 :)

@senthilmanick
Copy link

Shazron,
I think it is a minor typo. Fixed in 1.3.3 senthilmanick/ios-deploy
-Senthil

@shazron
Copy link

shazron commented Nov 17, 2014

No this is the true fix. Tested

@zarko-tg
Copy link
Author

I can confirm, 1.3.2 resolved the issue in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants