Significantly reduced a time of lldb initialization when ios-deploy is used without --justlaunch flag
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/DeviceSupport/10.0/Symbols`) Also, removed a code duplication
…s used without `--justlaunch` flag The problem looked like a stuck after `(lldb) autoexit` message in the log. Before that fix I had 10 second delay for iPhone 6s and 40 seconds delay (sometimes much longer) for iPad 4. Now the time is comparable to the time of running the game from XCode. The problem was related with a lack of `target modules search-paths add ...` command which drastically reduces the time of a modules' loading. XCode uses exactly the same lldb command with the same arguments.
…n't be found because of incorrect usage of `find` command. Also, this function checks more path variations now
…t location. Added an execution time logging for `copy_xcode_path_for` function. (We have a buggy server which sometimes gets stuck there)
|
Hi @shazron, Thank you for your hard work on ios-deploy all these years. You really helped us a lot. You could probably worry that this patch has quite a few changes, but on the other hand, It makes ios-deploy to behave closer to XCode, fixes problems with searching device_support_path and, of course, makes ios-deploy running faster. We have ios-deploy with these changes constantly running by our server for a month without any problems (we had 3 iOS updates since then). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem looked like a stuck after
(lldb) autoexitmessage in the log.Before that fix, I had 10-second delay for iPhone 6s and 40 seconds delay (sometimes much longer) for iPad 4. Now the time is comparable to the time of running the game from XCode.
The problem was related to a lack of
target modules search-paths add ...command which drastically reduces the time of a modules' loading. XCode uses exactly the same lldb command with the same arguments.