Remove node/npm from README installation steps (in favor of brew) #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't abandoning node/npm yet... but with the odd issues in #415 it's prudent to not direct people toward node when we aren't really using it.
gabebear
changed the title
Closed
6 tasks
geekonion
pushed a commit
to geekonion/ios-deploy
that referenced
this pull request
Jun 29, 2023
Remove node/npm from README installation steps (in favor of brew) Verified that this fixes the issue we saw in ios-control#415 ... but still not sure why npm is failing.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't abandoning the npm package, there are 37 dependent packages on https://www.npmjs.com/package/ios-deploy that we don't want to break!
BUT, with the odd issues in #415 it's prudent to not direct people toward node when they are wanting to install ios-deploy for command line use. Directing users to install ios-deploy via brew cuts down the number of steps and seems to be less flaky.