Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Large Incremental Installs #470

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Fix Large Incremental Installs #470

merged 2 commits into from
Aug 19, 2020

Commits on Aug 17, 2020

  1. Remove start/stop/disconnect session calls from calls to AMDeviceSecu… 

    …reInstallApplicationBundle. This version does not seem to need it and it appears this causes errors during long install operations where the session will timeout and reult in kAMDSendMessageError. The standard install method will fail without the start session call.

Information about AMDevice session behavior was gleaned from https://github.com/facebook/idb/blob/8172962dd871805127ad883ce99e75ae0f7bea44/FBDeviceControl/Management/FBAMDevice.h.
    @ivanhernandez13
    ivanhernandez13 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    faa5227 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Simplify comment with reasoning for not starting an AMDevice session … 

    …for incremental installs.
    @ivanhernandez13
    ivanhernandez13 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    54c0a6b View commit details
    Browse the repository at this point in the history