Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show finer progress when installing #515

Merged
merged 2 commits into from Jun 3, 2021
Merged

Show finer progress when installing #515

merged 2 commits into from Jun 3, 2021

Conversation

nisargjhaveri
Copy link

Fix #514: Installation seems stuck when the bundle has a large file

Print message when overall progress percentage changes.

gabebear
gabebear requested changes Jun 1, 2021
View reviewed changes
Copy link

@gabebear gabebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense so we don't spam with the same percent.

src/ios-deploy/ios-deploy.m Show resolved Hide resolved
@nisargjhaveri
Copy link
Author

@gabebear Thanks for the suggestion. Updated.

@ivanhernandez13 ivanhernandez13 merged commit df7d9f1 into ios-control:master Jun 3, 2021
@nisargjhaveri nisargjhaveri deleted the finer_install_progress branch June 3, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabebear gabebear gabebear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation seems stuck when the bundle has a large file
3 participants
@nisargjhaveri @gabebear @ivanhernandez13