Add a command to check whether a device has enabled developer mode. D… #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eveloper mode was introduced in iOS 16. When checking devices on older versions the command will print an unsupported error.
gabebear
requested changes
Jun 27, 2022
gabebear
requested changes
Jun 27, 2022
…tements to NSLogOut statements.
gabebear
approved these changes
Jun 28, 2022
chenrui333
reviewed
Jun 29, 2022
| @@ -91,6 +91,7 @@ | |||
| mach_error_t AMDeviceLookupApplications(AMDeviceRef device, CFDictionaryRef options, CFDictionaryRef *result); | |||
| int AMDeviceGetInterfaceType(AMDeviceRef device); | |||
| AMDeviceRef AMDeviceCopyPairedCompanion(AMDeviceRef device); | |||
| bool AMDeviceCopyDeveloperModeStatus(AMDeviceRef device, unsigned int *arg1); | |||
There was a problem hiding this comment.
Got some build issue for this
Undefined symbols for architecture arm64:
"_AMDeviceCopyDeveloperModeStatus", referenced from:
_check_developer_mode in ios-deploy.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
relates to Homebrew/homebrew-core#104730
There was a problem hiding this comment.
Oops, this symbol is new so Xcode 14 is required to build it. Will revert this commit and look into gating this to only be included when building with Xcode 14.
There was a problem hiding this comment.
Tested out the revert, works for me in my local. Thanks @ivanhernandez13!
ivanhernandez13
added a commit
that referenced
this pull request
Jun 30, 2022
This reverts commit aa870b5.
ivanhernandez13
added a commit
to ivanhernandez13/ios-deploy
that referenced
this pull request
Aug 11, 2022
This reverts commit aa870b5.
ivanhernandez13
added a commit
to ivanhernandez13/ios-deploy
that referenced
this pull request
Aug 11, 2022
…eveloper mode was introduced in iOS 16. When checking devices on older versions the command will print an unsupported error. Retry of ios-control#556 that guards the developer mode check by a preprocessor define so that it is not build by default. Developer mode requires a MobileDevice method introduced with Xcode 14 so including it by default will break builds where Xcode 14 is unavailable.
ivanhernandez13
added a commit
to ivanhernandez13/ios-deploy
that referenced
this pull request
Aug 11, 2022
…eveloper mode was introduced in iOS 16. When checking devices on older versions the command will print an unsupported error. Retry of ios-control#556 that guards the developer mode check by a preprocessor define so that it is not build by default. Developer mode requires a MobileDevice method introduced with Xcode 14 so including it by default will break builds where Xcode 14 is unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eveloper mode was introduced in iOS 16. When checking devices on older versions the command will print an unsupported error.