Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ledger gap limit #1320

Merged
merged 10 commits into from
Jul 30, 2021
Merged

fix: Ledger gap limit #1320

merged 10 commits into from
Jul 30, 2021

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Jul 29, 2021 •
edited
Loading

Description of change

This PR fixes the unnecessary address generation on Ledger devices by using the getSyncAccountOptions result where needed.

Links to any relevant issues

None

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Tested on (w/ Ledger Nano S):

  • MacOS (Catalina 10.15.7)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@maxwellmattryan maxwellmattryan marked this pull request as ready for review July 29, 2021 21:30
@cvarley100 cvarley100 merged commit ec66ba8 into feat/ledger Jul 30, 2021
@cvarley100 cvarley100 deleted the fix/ledger-gap-limit branch July 30, 2021 01:21
cvarley100 added a commit that referenced this pull request Aug 5, 2021
@cvarley100 @lucasfernog
@begonaalvarezd @laumair @rajivshah3 @maxwellmattryan @Thoralf-M @dependabot @github-actions @crowdin-bot @r-c-k
feat: add Ledger Nano support (#1373)
d3d21b2 
* refactor: rename accountType to profileType

* fix: client options on firefly import

* fix: no need to save profile on ledger, it's saved on Congratulations

* feat: do not check stronghold status on ledger profile

* fix: ledger import goes to Protect (set PIN) route

* feat(dashboard): add `Locked` label

* fix(router): ledger setup router

* fix imports

* wip update ledger views

* fix import

* chore: resolve remaining merge conflicts

* wip update ledger views

* Update ledger views

* add comment

* Update Ledger popup style

* Add missing break in route to prevent ledger getting into password flows

* Update locales

* add missing imports to wallet.svelte

* Update ledger popup handler

* Rename ConfirmBalance file to Balance

* Update ledger balance ui

* Update import success

* Reorder ledger import view files

* wip trinity ledger views

* add reamining basic UI for ledger trinity import

* chore: update nodes and network

* Add index component style (missing  validation)

* store profileType in profile level and centralize ledger simulator flag

* add ledger UI icons to profile selection and account tile

* small ledger import UI improvement

* fix doc comment

* fix setProfileType

* centralize isSoftwareProfile

* fix new software profile wrongly skipping backup

* feat: remove duplicate initialiseListeners() declaration

* add ledger error message

* remove remaining standalone simulator flag

* perform stronhold actions only on software profiles

* update ledger dashboard security section

* update ledger dashboard security UI

* Update securityTile based on UX request

* maintain ledger status check after connection detected

* ledger profile UI retouch

* rewrite ledger connection interval in security view

& add spinner loader to security ledger status

* remove stronghold related processes on ledger upon login and on sync click

* Add preloader spinner to progressbar for when ledger is busy before allowing to send

* hotfix: do not attempt to recreate accounts

* Do stronghold actions on logout only for software profiles

* Reorder ledger/import routing and views so pin setup goes before ledger

* chore: update backend

* Feat: add progress flow to trinity ledger (#1)

Co-authored-by: Ruben Alvarez <ralvarez@boxfish.studio>

* chore: do initial (library) setup for trinity to ledger migration

* feat: hook up address generation & display during trinity to firefly ledger migration

* feat: hook up getMigrationAddress() & mineBundle()

* hotfix: properly expose class methods from Ledger class

* Remove unnecessary progress from onboarding ledger balance

* chore: copy bindings file during build

* connect non-happy migration flows to ledger

* Add ledger page number selector

* revert plus/minus number component

* Remove "re-generate" address from ledger migration

* progressbar css fix

* feat: hook up account fetching APIs

* Add ledger icon to popups

* Add ledger legacy app popup

* chore: set asar to false

* feat: integrate legacy to new migration (single bundles)

* Add iframe video component

* Add migration video to ledger onboarding

* Add send ledger confirmation popups

* fix CSS in progressbar

* fix(desktop): Fix issues loading HID and USB bindings (#1210)

Because of issues with the `bindings` package, we need to hardcode the paths to the bindings

* Fix extra colon in video string

* fix: set minimize flag to false

* fix ledger state machine entering on multiple states

* Rename views

* unify ledger connection during onboarding

* add missing getLedgerDeviceStatus api function

* fix: update bindings lock file

* feat: integrate spent addresses & multiple addresses migration flow

* chore: fix comment

* chore: update rust deps

* feat: update getMigrationAddress() interface

* fix: Disable back button on sensitive migration steps

* feat: store all migration bundles in log file

* fix: Ledger disconnect polling (#1222)

* fix: only poll once ledger is disconnected

* fix: use callbacks on ledger connect and cancel

* fix: import firefly ledger disconnect popup

* fix: cleanup Ledger connection functions

* fix: update dashboard ledger connection polling

* chore: remove logs

* fix: migration connection prompt

* fix: dashboard ledger poll interval

* fix: immediately poll or ledger device status

* fix: ensure ledger spinner actually spins

* fix: callback function name

* chore: point to dev wallet-rs branch and update lock file

* fix: remove ledger import sync

* feat: Ledger migration popup guide (#1227)

* feat: Add onboarding layout for Ledger app guide

* feat: Add functional popup guide

* feat: Add locale JSON data for new next

* fix: Adjust styling and remove unnecessary locale data

* reduce gapLimit for ledger accounts (#1233)

* Feat: update ledger setup UI (#1230)

* Add new ledger onboarding UI (missing logic)

* remove unused illustration

* add connection guide and missing guides assets

* add ledger popup logic (no legacy)

* update ledger UI

* remove unused ledger view

* adapt ledger migration progress to new UI

* update assets

* refactor: cleanup unnecessary code

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: Ledger transaction error (#1229)

* fix: Change error mapping for transaction cancellation (on Ledger)

* fix: Move error locale to better place

* feat: Ledger connection on send (#1232)

* feat: Add functional popup for ensuring Ledger is connected on send

* feat: Add second connection check and cleanup code

* fix: Set simulator flag and fix import path

* chore: refactor ledger send prompt functions

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: display error when syncing a ledger profile

* fix: stop polling ledger status on logout

* chore: point hw-app-iota to latest

* feat: display legacy address on the UI (#1234)

* chore: update wallet-rs branch

* fix: reset migration state on back press from ledger balance

* fix: add user-facing ledger errors

* fix: only display balanceFinder password for software profiles

* fix: update Ledger strings

* fix: ensure there is no unnecessary address generation

* feat: Ledger migration address confirmation (#1237)

* feat: Add display function for confirming migration address

* fix: Switch backend branch and handle edge cases

* feat: Disable confirm button for Ledger use

* fix: Revert some variable names

* Set boolean flag in different place for UX

* feat: Account index validator (#1231)

* feat: Add basic validator for address index (migration data)

* feat: Add input validation for account index / page

* fix: Ensure min / max defaults and modify validation method

* fix: Cleanup code

* feat: Modify error message

* feat: Add errors for account page

* feat: add account index offset (#1241)

* chore: update hw-app-iota to latest (#1243)

* feat: Ledger opened app (#1228)

* feat: Expose API endpoint for getting opened Ledger app

* feat: Add more specific ledger state info

* fix: Remove nested API call

* feat: Add more locale data for new states

* feat: Add connection logic in Connect.svelte

* fix: Fix mistake made earlier (misplaced line)

* chore: update rust lock file

* fix: reduce ledger connection poll interval

* chore: fix incorrect string

* chore: update rust deps

* feat: Add locked state and fix some UX

* fix: Make changes per PR comments

* fix: Change return type to match changes in wallet.rs

* fix: Remove console log statement

* Feat: Ledger legacy connection popup (#1240)

* Add ledger legacy onboarding connection popups

* Disable onboarding back button on busy

* remove electron listener

* add locked state to ledger legacy popups & code cleanup

* add legacyConnected message to dashboard

* cleanup variable

* Improve busy button states

* fix locale from previous commit

* chore: update hw-app-iota to latest (#1243)

* fix: update connected state string

* remove ledger dependency from secure spent addresses

* fix legacy popup on transfer fragmented funds

Co-authored-by: Umair Sarfraz <umair.sarfraz@iota.org>
Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: update backend deps

* fix: remove getLedgerOpenedApp api

Co-authored-by: Charlie Varley <charlie.varley@iota.org>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: Umair Sarfraz <umair.sarfraz@iota.org>

* merge ledger balance view (#1245)

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* Feat: css fixes (#1250)

* fix popup sizes

* fix connect icons

* center ledger app texts

* remove margin-top from tx amount

* set popup size reactive

* improve status icons

* Fix debugging CSS

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* Update ledger illustrations (#1249)

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: incorrect variable usage

* Move variable to the top of the file to avoid access before initialization (#1257)

* fix: Ledger transaction prompt (#1246)

* feat: Expose API endpoint for getting opened Ledger app

* feat: Add more specific ledger state info

* fix: Remove nested API call

* feat: Add more locale data for new states

* feat: Add connection logic in Connect.svelte

* fix: Fix mistake made earlier (misplaced line)

* chore: update rust lock file

* fix: reduce ledger connection poll interval

* chore: fix incorrect string

* chore: update rust deps

* feat: Add locked state and fix some UX

* fix: Make changes per PR comments

* feat: Add popup with some (not all) prompts

* fix: Change return type to match changes in wallet.rs

* fix: Remove console log statement

* feat: Add more event types for transfer progress

* feat: Add basic support for new event types

* fix: Add functional transaction prompt(s) with error handling

* fix: Change string->boolean conversion

* fix: Fix last merge conflicts

* fix: Change var name for other commit

* chore: Make more generic error message

* chore: Adjust messages and formatting

* feat: Add polished UI popups for Ledger transaction flows

* chore: Cleanup code and add a little error handling

* fix: Remove straggling code and diff issues

* chore: Improve error messages and feedback

* chore: Polish code and styling

* fix: Revert back to old changes for locale and Connect

* chore: Fine-tune code comments and formatting, change locale data

* feat: Add Ledger state for 'OtherConnected'

* chore: Change locale prop for consistency

* feat: Add app name specificity to device state

* fix: Handle on error for device state and also locale data

* chore: Improve truthy checks for variables

* feat: Add better feedback and error handling for Ledger states

* fix: Remove error spam on invalid tx data for popup

* feat: Add timed notifications for when locked and in Send route

* chore: Add improvements per PR comments

* fix: Remove straggling codes

* fix: Use existing UTXO types in transfer events

* chore: Add better data parsing for tx

* chore: Remove code formatting issues

* chore: Improve typing for transaction input during transfer

* chore: Improve typing again for UTXO event data

* fix: remove variable reactivity

* chore: format and improve readability

* chore: update ledger strings

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* feat: Integrate legacy app simulator setup (#1251)

* chore: update hw-app-iota to latest

* feat: integrate legacy app simulator setup

* Update legacy simulator port

Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>

* chore(temp): add ledger migration node (#1262)

* chore(temp): add ledger migration node

* chore: add legacy permanode

* feat: add receive address prompt for Ledger  (#1260)

* chore: update wallet-rs branch

* feat: display a prompt to check receive address for ledger

* fix: use correct profile check

* chore: remove unused code

* fix: block ledger address gen if syncing

* fix: isSyncing prop

* fix: Remove some error spam and add locale data

* chore: Fix code import formatting

* chore: Make code reversion and add new notification function

Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* Feat: Add ledger legacy migration transaction popup (#1255)

* feat: Expose API endpoint for getting opened Ledger app

* feat: Add more specific ledger state info

* fix: Remove nested API call

* feat: Add more locale data for new states

* feat: Add connection logic in Connect.svelte

* fix: Fix mistake made earlier (misplaced line)

* chore: update rust lock file

* fix: reduce ledger connection poll interval

* chore: fix incorrect string

* chore: update rust deps

* feat: Add locked state and fix some UX

* fix: Make changes per PR comments

* feat: Add popup with some (not all) prompts

* fix: Change return type to match changes in wallet.rs

* fix: Remove console log statement

* feat: Add more event types for transfer progress

* feat: Add basic support for new event types

* fix: Add functional transaction prompt(s) with error handling

* fix: Change string->boolean conversion

* fix: Fix last merge conflicts

* fix: Change var name for other commit

* chore: Make more generic error message

* chore: Adjust messages and formatting

* feat: Add polished UI popups for Ledger transaction flows

* chore: Cleanup code and add a little error handling

* fix: Remove straggling code and diff issues

* chore: Improve error messages and feedback

* chore: Polish code and styling

* add ledger legacy migration transaction popup

* fix: Revert back to old changes for locale and Connect

* chore: Fine-tune code comments and formatting, change locale data

* feat: Add Ledger state for 'OtherConnected'

* chore: Change locale prop for consistency

* feat: Add app name specificity to device state

* close popup earlier

* fix: Handle on error for device state and also locale data

* chore: Improve truthy checks for variables

* feat: Add better feedback and error handling for Ledger states

* fix: Remove error spam on invalid tx data for popup

* feat: Add timed notifications for when locked and in Send route

* chore: Add improvements per PR comments

* fix: Remove straggling codes

* improve types

* add legacy address with checksum

* add missing else from previous commit

* cleanup code

* Code cleanup

* fix merge

* expose getLegacyAddressChecksum api

* update cargo

* add LegacyAddressChecksum validator

* add getLegacyAddressChecksum to walletApi

* Undo cargo update

* improve documentation

* Improve async code

* add bridge responses

* hide legacy address checksum

Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: fix account index string

* chore(temp): enable dev tools

* chore: enable developer tools menu item

* chore: point backend to latest wallet-rs (#1267)

* Fix: Update response type for getLegacyAddressChecksum api (#1268)

* fix: Ledger null addresses (#1271)

* fix: Handle null address case

* chore: Move openPopup to happen on event

* fix: remove unnecessary popup timeout

* chore: fix string

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: ensure js Ledger connection is closed and other fixes (#1272)

* fix: close legacy connection after getting migration data

* fix: remove unnecessary ledger status checks

* fix: globally poll from security panel

* fix: add transport disconnect callback to createLedgerMigrationBundle and createMinedLedgerMigrationBundle

* fix legacy tx poopup not closing at right time (#1273)

* feat: remove unnecessary code related to ledger simulator (#1269)

* Feat: Add ledger legacy migration toast errors (#1275)

* Add ledger legacy migration toast errors

* remove unnecessary comment

* fix: change ledger security panel item colour

* fix: reduce ledger dashboard poll frequency

* fix: manually trigger polling on dashboard mount (#1276)

* fix: disable simulator use

* chore: Remove remote and IPC usage from Ledger (#1254)

* chore: Remove remote and IPC usage from Ledger

* chore: Disable remote module

* chore: remove unused code

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: correctly handle user denying ledger migration (#1277)

* chore: Remove remote and IPC usage from Ledger

* chore: Disable remote module

* chore: remove unused code

* fix: close transport on user deny of ledger migration transaction

Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

* chore: update Ledger strings

* chore: update Ledger string

* fix: ledger installation string

* fix: ledger installation string

* fix: Ledger string

* hotfix: keep track of spent addresses during (ledger) migration (#1281)

* fix: Ledger state handling (#1274)

* feat: Add Ledger state handling for BalanceFinder

* feat: Add Ledger state handling for Connect

* feat: Add handling for migration case in Connect

* chore: Cleanup code and remove unused imports

* chore: Refactor Ledger state handling in migration

* chore: Refactor Ledger state handling for Send

* chore: Add prompt call back in

* chore: Address popup adjustments (#1280)

* feat: Add Ledger state handling for BalanceFinder

* feat: Add Ledger state handling for Connect

* feat: Add handling for migration case in Connect

* chore: Cleanup code and remove unused imports

* chore: Refactor Ledger state handling in migration

* chore: Refactor Ledger state handling for Send

* chore: Make address confirmation easier with string chunking

* chore: Fine tune stylings and remove Ledger formatting:

* fix: bad merge

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: Ledger popups (#1282)

* feat: Add Ledger state handling for BalanceFinder

* feat: Add Ledger state handling for Connect

* feat: Add handling for migration case in Connect

* chore: Cleanup code and remove unused imports

* chore: Refactor Ledger state handling in migration

* chore: Refactor Ledger state handling for Send

* feat: Add preventClose prop to popup state and implement where needed

* chore: Add locale data and cleanup code

* chore: Add prompt call back in

* chore: Add migration handling for edge case

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* Feat: add ledger animations (#1283)

* Add ledger animations

* add animations to popups

* update animations

* update illustration

* Update animation

* cleanup code

* add animations to ledger guides

* add missing darkmode illustration

* bring back darkmode illustrations because of the shades

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: Address formatting (#1285)

* chore: Fix the address formatting and improve some

* fix: Don't forget style tag

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: Sync account logic (#1284)

* chore: Refactor sync account logic

* chore: Small code formatting change

* chore: Fix straggling code logic

* fix: adjust profile declaration

* fix: import spacing

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: remove unused symbol

* fix: missing imports

* Feat: Remove checksum from end of ledger output (#1288)

* remove checksum from ledger output address

* fix imports

* fix: minimum migrateable balance

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: Add external link to migration page (#1290)

* Fix: Hardcode non-translatable ledger strings (#1289)

* Remove non-translatable ledger strings and hardcode them

* make "IOTA Legacy" a constant string

* Fix: ledger locales (#1293)

* fix ledger guides locales

* Fix locale variable

* Chore: merge develop into feat/ledger (#1295)

* chore(deps): bump normalize-url from 4.5.0 to 4.5.1 (#1197)

Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump color-string from 1.5.4 to 1.5.5 (#1220)

* chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#1221)

* fix: PR change types (#1226)

* fix: Add "chore" and "refactor" change types to PR template

* docs: update pull_request_template.md

* docs: update pull_request_template.md

* Update pull_request_template.md

Co-authored-by: Charlie Varley <cvarley100@gmail.com>

* New Crowdin translations by Github Action (#1202)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* Reversed order of node context menu options (#1173)

* chore: IBM Plex Mono font (#1224)

* chore: Replace DM Mono with IBM Plex Mono

* fix: Adjust font weight and size to match design

* Add instructions how to update wallet.rs in the backend (#1253)

* add instructions how to update wallet.rs

* Update packages/backend/README.md

Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

* chore: cherry pick ledger strings (#1278)

* chore(ci): Upload releases to firefly bucket prefix (#1122)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Charlie Varley <cvarley100@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Richard K <17240275+r-c-k@users.noreply.github.com>
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

* fix: Ledger state errors (#1286)

* fix: Handle more cases for Ledger state errors

* chore: Make slight code changes for diffs

* fix: Account for non-Ledger errors

* chore: Cleanup code and self-review

* chore: Tiny formatting change

* chore: Remove submessages and properly handle Ledger profile errors

* chore: Remove unused import

* chore: Add handling for fragmented funds view

* fix: Remove software profile bug

* chore: update node (#1300)

* Feat: Icon link (#1296)

* add icon to link component

* Update links usage with icon

* Add info icon to ledger migration read more

* fix CSS

* fix: reduce icon size and spacing

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* Feat: Update ledger assets (#1294)

* Update ledger assets with new shadow

* CSS fix

* Update address pre sizes

* update animation with new shadow

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* feat: add tooltip when finding balance takes too long and fix back button behaviour (#1291)

* feat: add tooltip suggestion if finding balances spins indefinitely

* fix: store ledger state history to enable back from balance page

* chore: cleanup unused imports

* New Crowdin translations [ci skip] (#1292)

* chore(deps): bump normalize-url from 4.5.0 to 4.5.1 (#1197)

Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump color-string from 1.5.4 to 1.5.5 (#1220)

* chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (#1221)

* fix: PR change types (#1226)

* fix: Add "chore" and "refactor" change types to PR template

* docs: update pull_request_template.md

* docs: update pull_request_template.md

* Update pull_request_template.md

Co-authored-by: Charlie Varley <cvarley100@gmail.com>

* New Crowdin translations by Github Action (#1202)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* Reversed order of node context menu options (#1173)

* chore: IBM Plex Mono font (#1224)

* chore: Replace DM Mono with IBM Plex Mono

* fix: Adjust font weight and size to match design

* Add instructions how to update wallet.rs in the backend (#1253)

* add instructions how to update wallet.rs

* Update packages/backend/README.md

Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

* chore: cherry pick ledger strings (#1278)

* chore(ci): Upload releases to firefly bucket prefix (#1122)

* Fixed typo (#1298)

Changed "you" to "the"

* New Crowdin translations by Github Action (#1279)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* New Crowdin translations by Github Action

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Charlie Varley <cvarley100@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Richard K <17240275+r-c-k@users.noreply.github.com>
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: update backend (#1301)

* chore: update node

* chore: update backend

* reinitialize ledger route onMount (#1303)

* Fix: reinit ledger route only on fresh onboardings (#1310)

* reinitialize ledger route onMount

* reinitialize ledger router only if not in the middle of a ledger flow

* Remove unnecessary code

* Feat: check for new ledger app open after migration  (#1305)

* Add ledger iota app connection check to ledger migration congrats view

* Add comment

* Fix: ledger guides locales (#1302)

* fix ledger guides continue/close buttons

* Remove unused locales

* chore: fix locale json

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: Mismatch address-index pair (#1308)

* feat: Add disable prop to Number component

* chore: Add opacity change on disabled

* fix: Ledger error on load (#1314)

* fix: Remove error on load for Ledger

* fix: adjust error suppression logic

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* feat: merge Ledger next (#1313)

* chore: update node

* chore: update backend

* Add ledger migrate another index popup and basic routing

* Update new ledger index migration routing to keep track of history

* feat: display ledgerMigrateIndex popup only once

* Add ledger index migration to settings

* feat: do not re-create profile if a user is migration additional account index

* feat: initialise ledger migration listeners when Ledger parent component is mounted

* chore: merge feat/ledger

* feat: some updates

- Merge dummy and actual messages;
- Do not allow creating new accounts if the latest is empty
- Remove unnecessary console logs

* Reset wallet route before navigating to a new index migration

* add missing import

* chore: remove unnecessary condition

* chore: disable simulator

* chore: remove log statement

* fix: use correct profile definition

* fix: use correct profile definition

* chore: remove unused import

* chore: remove unused imports

* fix: Automatic popup closes (#1311)

* fix: Add preventClose prop to necessary popup

* chore: Change to better store variable

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* hotfix: only display transaction index pop up for migrated ledger profiles (#1315)

Co-authored-by: Umair Sarfraz <aquadestructor@icloud.com>
Co-authored-by: Begoña Alvarez <balvarez@boxfish.studio>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Umair Sarfraz <umair.sarfraz@iota.org>

* fix: update account index popup (#1316)

* chore: update node

* chore: update backend

* Add ledger migrate another index popup and basic routing

* Update new ledger index migration routing to keep track of history

* feat: display ledgerMigrateIndex popup only once

* Add ledger index migration to settings

* feat: do not re-create profile if a user is migration additional account index

* feat: initialise ledger migration listeners when Ledger parent component is mounted

* chore: merge feat/ledger

* feat: some updates

- Merge dummy and actual messages;
- Do not allow creating new accounts if the latest is empty
- Remove unnecessary console logs

* Reset wallet route before navigating to a new index migration

* add missing import

* chore: remove unnecessary condition

* chore: disable simulator

* chore: remove log statement

* fix: use correct profile definition

* fix: use correct profile definition

* chore: remove unused import

* chore: remove unused imports

* fix: Automatic popup closes (#1311)

* fix: Add preventClose prop to necessary popup

* chore: Change to better store variable

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: update migration prompt strings

* fix: update account index popup

Co-authored-by: Umair Sarfraz <aquadestructor@icloud.com>
Co-authored-by: Begoña Alvarez <balvarez@boxfish.studio>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>

* Feat: Remove chrysalis network upgrade checks and notification (#1312)

* Remove chrysalis down notification and polling logic

* add active profile check

* fix: remove status check

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* chore: update backend

* hotfix: use correct account index for displaying address

* hotfix: ensure balance finding works correctly

* Feat: Remove `legacyAddressForTesting` (#1321)

* Remove legacy address from Balance view

* remove legacyAddressForTesting

* code unused variable

* Feat: add ledger support slide to connection guide (#1319)

* Add support slide to ledger connection guide

* Update ledger open app illustration

* fix CSS

* chore: fix string

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: ensure correct address display for mined bundles (#1323)

* Feat: update ledger index migration popup buttons (#1322)

* Update ledger index migration popup buttons

* add forceClose to popup shared logic

* sort imports

* chore: update index popup string

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: Ledger gap limit (#1320)

* fix: Modify logic and use where needed

* chore: Improve logic and handle different profile cases

* chore: Cleanup code

* fix: Add detection for first manual sync

* fix: adjust balance finder logic

* chore: rename isFirstSync

* fix: store isFirstManualSync in store

* fix: increment account discovery index on balance finder

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* Feat: Remove waiting for funds dashboard lock (#1318)

* fix waiting funds notification showing up multiples times

* Remove waiting funds wallet lock

* replace missing isLedgerProfile

* Fix: some CSS (#1326)

* fix jumping slide

* add missing scroll on ledger transaction popup

* Fix: dashboard ledger prompt (#1325)

* fix dashboard prompt not working when ledger not connected vecause of ongoing poll

* move ledger poll to dashboard instead of security view

* fix stop/start poll race condition

* fix: Ledger migration connection (#1324)

* fix: Add reactive function on device state

* fix: adjust migration logic

* fix: ensure transfer fragmented funds behaves

* fix: ledger string

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: ensure mined bundle checksum is correct (#1327)

* fix: show account index tooltip immediately when checking for balance (#1328)

* fix: display account index tooltip immediately on balance check

* fix: adjust account index tooltip string

* fix: legacy string

* chore: update to Electron 11 (#1329)

* Update Electron to 11.4.10

* fix: enable webpack minimize

Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>

* fix: mask all Ledger errors on load (#1334)

* fix: stop prevent close error on account index popup  (#1335)

* fix: ensure busy state timeout does not attempt to close account index popup

* fix: remove popup used for debugging

* Fix/dashboard poll (#1338)

* stop ongoing poll only if it wasnt alredy interrupted

* stop ongoing poll only if its a normal situation or it there was an interruption

* stop dashboard poll when leaving the dashboard route

* remove unnecessary stop ledger poll from the ledger not connected popup

* hotfix: reset migration listeners state when all event listeners are destroyed on the active actor (#1340)

* feat: disable background sync

* hotfix: reset migration event listeners state when all listeners are removed

* feat: re-enable background sync

* fix: stops background syncing during migration of additional indexes (#1341)

* fix: stop background sync on additional account index migration

* chore: remove log statement

* hotfix: mark migration complete if user denies last migration tx (#1342)

* feat: disable background sync

* hotfix: reset migration event listeners state when all listeners are removed

* feat: re-enable background sync

* chore: mark migration complete if user denies last migration tx

* add force flag to logout close popup to make sure all popups are closed (#1350)

* Fix: Ledger migration skipping congratulations view (#1346)

* Add missing unsubscriptions on view destroy

* undo unsubscribes, no time for testing all now

* Improve ledger transaction distance CSS (#1349)

* chore: Adjust balance string (#1345)

* chore: update backend (#1347)

* remove MigrateLedgerIndex from non ledger profiles (#1348)

* fix: adjust address index ux when taking a while (#1352)

* fix: adjust account index taking a while view

* fix: remove instruction to delete legacy app

* fix: New profile transaction history  (#1353)

* fix: Add extra conditional check for UI logic

* chore: Add explanitve code comment

* fix: handle uncaught error (#1354)

* fix: simplify ledger status polling (#1343)

* fix: simplify ledger status polling system

* fix: ensure correct poll function is used to initiate polling

* chore: update backend

* fix: Undefined migration inputs (#1355)

* fix: Add notification for missing bundle data

* chore: fix formatting

Co-authored-by: Charlie Varley <charlie.varley@iota.org>

* fix: ensure correct bundle is selected with multiple mines (#1356)

* fix: Correct string for creating first profiles

* fix: add missing video string

* hotfix: correctly set busy state during migration (#1358)

* Feat: add final ledger video (#1360)

* add final ledger video url

* Remove video outline

* New Crowdin translations by Github Action (#1359)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: add correct bundle mining timeout

* fix: update to mainnet nodes

* fix: remove ledger account index offset

* fix: disable dev tools in production and remove menu item

* chore: update default network name

* chore: update backend

Includes: iotaledger/wallet.rs#725

* chore: update backend

Points to iotaledger/wallet.rs@ef2a2fe

* hotfix: ensure error notification is displayed on account creation (#1369)

* Feat: update ledger video (#1370)

* update ledger video

* add new ledger video url to electron whitelist

* Fix translations

* Fix Slovak translation

* Bump version to 1.2.0

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Co-authored-by: Begoña Alvarez <balvarez@boxfish.studio>
Co-authored-by: Umair Sarfraz <aquadestructor@icloud.com>
Co-authored-by: Ruben Alvarez <ralvarez@boxfish.studio>
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Co-authored-by: Umair Sarfraz <umair.sarfraz@iota.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Richard K <17240275+r-c-k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvarley100 cvarley100 cvarley100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxwellmattryan @cvarley100