-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust min rewards handling #1918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
cvarley100
pushed a commit
that referenced
this pull request
Dec 30, 2021
rajivshah3
pushed a commit
that referenced
this pull request
Dec 30, 2021
maxwellmattryan
approved these changes
Jan 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cvarley100
added a commit
that referenced
this pull request
Jan 24, 2022
* fix: Fix logic for passing number to `localize` function * feat: add developer profile indicator to dashboard * fix: pass correct account id during legacy ledger migration * update: add collapsible block around developer profile checkbox update: add confirmation popup for creating developer profile * update: prefix network name to address label on dev profile * fix(shared): Fix issue changing node URL (#1910) * chore: update backend * chore: remove empty style block * fix: strings * fix: remove warning signs from dev profile indicator * feat: add dismiss to dev profile indicator * New Crowdin translations by Github Action * fix: add pointer events * update: backend revs * update: optional variable formatting Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> * chore: merge new strings from #1918 (#1987) Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> * fix(shared): Localize "Advanced options" label (#1990) * fix: ensure syncing message only shows for valid pending transactions (#1978) * fix: ensure syncing message only displays if there are valid pending transactions on a wallet * chore: formatting * fix: improve valid pending transaction check * chore: formatting Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> * feat: adjust min rewards handling (#1918) * chore: remove unused code * feat: add minimum reward send warning * fix: clear unstake warning prompt on next click * fix: reuse staking address if there is an existing stake * chore: fix import Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.router.local> Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> * fix: dev indicator styling (#2001) Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> * New Crowdin translations by Github Action (#1988) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: allow change of install directory windows (#1743) * chore: allow to change installation directory on windows * chore: set installer to assisted rather than one click * chore: update version (#2003) Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> * update: add Tanglebay node (#2005) * chore: update version * update: add tanglebay node Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> * hotfix: bump wallet-rs to latest commit * temp: change wallet.rs commit * update: change wallet.rs to stable commit Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Umair Sarfraz <aquadestructor@icloud.com> Co-authored-by: Rajiv Shah <rajivshah1@icloud.com> Co-authored-by: Charlie Varley <cvarley100@gmail.com> Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.router.local> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Type of change
How the change has been tested
Change checklist