Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust min rewards handling #1918

Merged
merged 6 commits into from
Jan 2, 2022
Merged

Conversation

cvarley100
Copy link
Contributor

Description of change

  • Display a warning if user tries to send before they reached minimum balance

Type of change

  • Update (a change which updates existing functionality)

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that my latest changes pass CI tests
  • New and existing unit tests pass locally with my changes

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
cvarley100 pushed a commit that referenced this pull request Dec 30, 2021
rajivshah3 pushed a commit that referenced this pull request Dec 30, 2021
Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cvarley100 cvarley100 merged commit 095ff9d into develop Jan 2, 2022
@cvarley100 cvarley100 deleted the fix/min-rewards-addresses branch January 2, 2022 03:50
cvarley100 added a commit that referenced this pull request Jan 24, 2022
* fix: Fix logic for passing number to `localize` function

* feat: add developer profile indicator to dashboard

* fix: pass correct account id during legacy ledger migration

* update: add collapsible block around developer profile checkbox
update: add confirmation popup for creating developer profile

* update: prefix network name to address label on dev profile

* fix(shared): Fix issue changing node URL (#1910)

* chore: update backend

* chore: remove empty style block

* fix: strings

* fix: remove warning signs from dev profile indicator

* feat: add dismiss to dev profile indicator

* New Crowdin translations by Github Action

* fix: add pointer events

* update: backend revs

* update: optional variable formatting

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>

* chore: merge new strings from #1918 (#1987)

Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>

* fix(shared): Localize "Advanced options" label (#1990)

* fix: ensure syncing message only shows for valid pending transactions (#1978)

* fix: ensure syncing message only displays if there are valid pending transactions on a wallet

* chore: formatting

* fix: improve valid pending transaction check

* chore: formatting

Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>

* feat: adjust min rewards handling (#1918)

* chore: remove unused code

* feat: add minimum reward send warning

* fix: clear unstake warning prompt on next click

* fix: reuse staking address if there is an existing stake

* chore: fix import

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>

Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.router.local>
Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>

* fix: dev indicator styling (#2001)

Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>

* New Crowdin translations by Github Action (#1988)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: allow change of install directory windows (#1743)

* chore: allow to change installation directory on windows

* chore: set installer to assisted rather than one click

* chore: update version (#2003)

Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>

* update: add Tanglebay node (#2005)

* chore: update version

* update: add tanglebay node

Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>

* hotfix: bump wallet-rs to latest commit

* temp: change wallet.rs commit

* update: change wallet.rs to stable commit

Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Umair Sarfraz <aquadestructor@icloud.com>
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
Co-authored-by: Charlie Varley <cvarley100@gmail.com>
Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.local>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Charlie Varley <charlievarley@MacBook-Pro.router.local>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants