fix: check if an onClick handler is defined before calling it #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
force-pushed
the
fix/profile-onclick-undefined
branch
from
a66bc17
to
7f9c392
Compare
nicole-obrien
approved these changes
Apr 8, 2022
nicole-obrien
added a commit
that referenced
this pull request
Apr 9, 2022
* chore: incremenet version to 1.4.0-beta-1 * fix: improve wording for theme settings hint (#2654) * fix: change URL for reporting an issue * fix: minimum rewards popup warning (#2684) * chore: manually sync new translations from Crowdin * fix: cancel any requests to select a Bluetooth device (#2693) * fix: cancel any requests to select a Bluetooth device * chore: Ignore vulnerability in Snyk * chore: update wallet.rs to fix missing addresses (#2695) Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * chore: increment version to 1.4.0-beta-2 * chore: sync latest translations from Crowdin * chore: upload PDB files when building Windows (#2721) * chore: increase network timeout for Yarn on CI (#2722) * chore: add comment explaining network timeout threshold increase * fix: rename account issues for 1.4.0 (#2720) * fix: rename profile issues * Update return type for onSubmitClick * Update packages/desktop/App.svelte Co-authored-by: Rajiv Shah <rajivshah1@icloud.com> * Update packages/shared/lib/app.ts Co-authored-by: Rajiv Shah <rajivshah1@icloud.com> * fix: make hasRenamedProfileFoldersToId persistent Co-authored-by: Rajiv Shah <rajivshah1@icloud.com> * chore: increment version to 1.4.0-beta-3 * chore: fix workflow * chore: increment desktop version to 1.4.0 * fix: retain original error structure when sending error to Sentry (#2727) * chore: Use Sectigo timestamp server on Windows * chore: use Sectigo RFC 3161 timestamp server on Windows * chore: update wallet.rs to fix transaction history * chore: increment desktop version to 1.4.1-beta * fix: missing autosubscription in dashboard * chore: increment desktop version to 1.4.1 * chore: update wallet.rs to fix Unicode paths on Windows (#2785) * fix: check if an onClick handler is defined before calling it (#2790) * fix: error handling of invalid timestamps (#2796) * fix: error handling of invalid timestamps * fix: invalid date and time in cvs export * fix: handle undefined index * chore: chore increment desktop version to 1.4.2 Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Rajiv Shah <rajivshah1@icloud.com> Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a user clicks on the
Profilecomponent on theEnterPinscreen, the app will report an error. In dev, this is reported as a warning when it renders:Changelog
Relevant Issues
Fixes #2788
Type of Change
Testing
Platforms
- [x] MacOS
Instructions
Click on the profile icon on the
EnterPinscreenChecklist