Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: units submodule #5009

Merged
merged 3 commits into from Oct 25, 2022
Merged

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Oct 24, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

This PR takes existing code from the old lib/units.ts file and refactors it into a utils submodule. It only deals with re-organizing code; NOT refactoring logic.

Changelog

- Refactor existing code into utils submodule
- Remove types file for `utils`

Relevant Issues

Please list any related issues using development keywords.

Closes #3973

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Tested general app functionality, particularly around the send flow.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Oct 24, 2022
@maxwellmattryan maxwellmattryan self-assigned this Oct 24, 2022
@maxwellmattryan maxwellmattryan linked an issue Oct 24, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@jeeanribeiro jeeanribeiro merged commit c83fcbc into stardust-develop Oct 25, 2022
@jeeanribeiro jeeanribeiro deleted the refactor/units-submodule branch October 25, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]: Create units core module
2 participants