Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance send tx popup #5218

Merged
merged 8 commits into from
Nov 21, 2022
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Nov 16, 2022

Summary

Added ethereum address validation as well as some UI fixes when switching between send NFT & send Token tab.

...

Changelog

- validate ethereum addresses
- correctly add network options depending whether NFT/Token transaction
- correctly reset fields

Relevant Issues

closes: #4850
...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Nov 16, 2022
@Tuditi Tuditi marked this pull request as draft November 16, 2022 11:10
@Tuditi Tuditi linked an issue Nov 17, 2022 that may be closed by this pull request
3 tasks
@Tuditi Tuditi force-pushed the feat/enhance-send-tx-popup branch 2 times, most recently from 0d5f90b to 09dd875 Compare November 18, 2022 10:38
@Tuditi Tuditi force-pushed the feat/enhance-send-tx-popup branch 2 times, most recently from 40a7d59 to 9f72a88 Compare November 18, 2022 12:34
@Tuditi Tuditi marked this pull request as ready for review November 18, 2022 15:36
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, added some comments/questions.

Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit 5186772 into stardust-develop Nov 21, 2022
@Tuditi Tuditi deleted the feat/enhance-send-tx-popup branch November 21, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Enhance send transaction popup for L1 -> L2 flow
2 participants