-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance send tx popup #5218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Tuditi
force-pushed
the
feat/enhance-send-tx-popup
branch
2 times, most recently
from
November 18, 2022 10:38
0d5f90b
to
09dd875
Compare
Tuditi
force-pushed
the
feat/enhance-send-tx-popup
branch
2 times, most recently
from
November 18, 2022 12:34
40a7d59
to
9f72a88
Compare
Tuditi
force-pushed
the
feat/enhance-send-tx-popup
branch
from
November 18, 2022 12:37
9f72a88
to
0f464dc
Compare
6 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, added some comments/questions.
packages/shared/lib/core/layer-2/utils/validateEthereumAddress.ts
Outdated
Show resolved
Hide resolved
MarkNerdi996
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added ethereum address validation as well as some UI fixes when switching between send NFT & send Token tab.
...
Changelog
Relevant Issues
closes: #4850
...
Testing
Platforms
Instructions
...
Checklist