Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove collection id form NFT minting #5228

Merged
merged 2 commits into from Nov 16, 2022

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

Changelog

Please write an accurate and concise changelog for your changes.

Relevant Issues

Please list any related issues (e.g. bug, task).

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien self-assigned this Nov 16, 2022
@nicole-obrien nicole-obrien added type:fix Fix for bug stardust Related to the Stardust Protocol labels Nov 16, 2022
@nicole-obrien nicole-obrien linked an issue Nov 16, 2022 that may be closed by this pull request
3 tasks
@kraftjs kraftjs self-requested a review November 16, 2022 19:31
Copy link
Contributor

@kraftjs kraftjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There are a few references collectionId in the en.json file. We might want to remove them to reduce bloat.

@nicole-obrien
Copy link
Contributor Author

Looks good to me. There are a few references collectionId in the en.json file. We might want to remove them to reduce bloat.

@kraftjs the collections will still have an Id so they will be used eventually

@kraftjs
Copy link
Contributor

kraftjs commented Nov 16, 2022

Looks good to me. There are a few references collectionId in the en.json file. We might want to remove them to reduce bloat.

@kraftjs the collections will still have an Id so they will be used eventually

Okay great, wasn't sure if that might be the case so I approved it instead of suggesting a change.

@nicole-obrien nicole-obrien merged commit f73bba1 into stardust-develop Nov 16, 2022
@nicole-obrien nicole-obrien deleted the fix/remove-nft-collection-id branch November 16, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove collectionId from IRC27 standard and mint form
2 participants