Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove collection id form NFT minting #5228

Merged
merged 2 commits into from
Nov 16, 2022
Merged

fix: remove collection id form NFT minting #5228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f2cf3
fix: remove collection id form NFT minting
nicole-obrien Nov 16, 2022
ce7d8e5
Merge branch 'stardust-develop' into fix/remove-nft-collection-id
nicole-obrien Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/shared/components/popups/MintNftConfirmationPopup.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

export let _onMount: (..._: any[]) => Promise<void> = async () => {}

const { standard, type, uri, name, collectionId, collectionName, royalties, issuerName, description, attributes } =
const { standard, type, uri, name, collectionName, royalties, issuerName, description, attributes } =
$mintNftDetails

$: isTransferring = $selectedAccount.isTransferring
Expand All @@ -23,7 +23,6 @@
name,
type,
uri,
...(collectionId && { collectionId }),
...(collectionName && { collectionName }),
...(royalties && { royalties }),
...(issuerName && { issuerName }),
Expand Down
1 change: 0 additions & 1 deletion packages/shared/lib/core/nfts/interfaces/irc27-metadata.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export interface IIrc27Metadata {
type: MimeType
uri: string
name: string
collectionId?: string
collectionName?: string
royalties?: Record<string, number>
issuerName?: string
Expand Down
1 change: 0 additions & 1 deletion packages/shared/lib/core/nfts/utils/parseNftMetadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export function parseNftMetadata(metadata: string): IIrc27Metadata {
type: parsedData.type as MimeType,
uri: parsedData.uri,
name: parsedData.name,
collectionId: parsedData.collectionId,
collectionName: parsedData.collectionName,
royalties: parsedData.royalties,
issuerName: parsedData.issuerName,
Expand Down
2 changes: 0 additions & 2 deletions packages/shared/lib/core/wallet/stores/mint-nft-details.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export const mintNftDetails = writable<IIrc27Metadata>({
type: undefined,
uri: undefined,
name: undefined,
collectionId: undefined,
collectionName: undefined,
royalties: undefined,
issuerName: undefined,
Expand All @@ -26,7 +25,6 @@ export function resetMintNftDetails(): void {
type: undefined,
uri: undefined,
name: undefined,
collectionId: undefined,
collectionName: undefined,
royalties: undefined,
issuerName: undefined,
Expand Down