New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address validation error behavior #5281
fix: address validation error behavior #5281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
||
import { selectedAccount } from '@core/account/stores' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reasons for the empty lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Matt added this, since the import comes from another module
packages/shared/lib/core/wallet/actions/activities/generateAndStoreActivitiesForAccount.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Currently
validateBech32Address
andvalidateEthereumAddress
are returning error strings instead of throwing actual errors.Changelog
Relevant Issues
Closes #5240
Testing
Platforms
Instructions
Test recipient address inputs with valid and invalid addresses / strings.
Checklist