Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address validation error behavior #5281

Merged
merged 17 commits into from Nov 25, 2022
Merged

fix: address validation error behavior #5281

merged 17 commits into from Nov 25, 2022

Commits on Nov 24, 2022

  1. chore: re-organize code

    @maxwellmattryan
    maxwellmattryan committed Nov 24, 2022
    Copy the full SHA
    0274378 View commit details
    Browse the repository at this point in the history

  2. fix: adjust logic using bech32 address validator

    @maxwellmattryan
    maxwellmattryan committed Nov 24, 2022
    Copy the full SHA
    3de1109 View commit details
    Browse the repository at this point in the history

  3. chore: fix logic around ethereum address validation

    @maxwellmattryan
    maxwellmattryan committed Nov 24, 2022
    Copy the full SHA
    0c61840 View commit details
    Browse the repository at this point in the history

  4. test: fix

    @maxwellmattryan
    maxwellmattryan committed Nov 24, 2022
    Copy the full SHA
    7363b9f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Merge branch 'stardust-develop' into fix/address-validation-error-beh… 

    …avior
    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    88e7cd4 View commit details
    Browse the repository at this point in the history

  2. chore: import bech32 dependency from iota instead of duplicating it i… 

    …n our own repo
    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    d72a94c View commit details
    Browse the repository at this point in the history

  3. chore: throw errors instead of returning booleans

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    d8741b5 View commit details
    Browse the repository at this point in the history

  4. fix: update import

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    8766c14 View commit details
    Browse the repository at this point in the history

  5. chore: removed dead code

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    4551bb7 View commit details
    Browse the repository at this point in the history

  6. chore: throw instead of return bool

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    19f304b View commit details
    Browse the repository at this point in the history

  7. chore: constant rename and refactor for throwing and error

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    3b73046 View commit details
    Browse the repository at this point in the history

  8. chore: add punctuation

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    d870405 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'stardust-develop' into fix/address-validation-error-beh… 

    …avior
    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    38a1c05 View commit details
    Browse the repository at this point in the history

  10. chore: fix pr review

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    c825fc2 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'stardust-develop' into fix/address-validation-error-beh… 

    …avior
    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    7384380 View commit details
    Browse the repository at this point in the history

  12. fix: tests

    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    b642375 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'stardust-develop' into fix/address-validation-error-beh… 

    …avior
    @Tuditi
    Tuditi committed Nov 25, 2022
    Copy the full SHA
    25fa76b View commit details
    Browse the repository at this point in the history