Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename index to question index #5496

Merged
merged 2 commits into from Dec 23, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 22, 2022

Summary

Correctly passes down the prop to ProposalQuestion

...

Changelog

- rename index to questionIndex

Relevant Issues

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Dec 22, 2022
@Tuditi Tuditi force-pushed the fix/rename-index-to-question-index branch from a13a94b to 0d6cea1 Compare December 22, 2022 16:53
@Tuditi Tuditi mentioned this pull request Dec 22, 2022
12 tasks
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit aea6f93 into stardust-develop Dec 23, 2022
@Tuditi Tuditi deleted the fix/rename-index-to-question-index branch December 23, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants