Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node url name #5497

Merged
merged 4 commits into from Dec 23, 2022
Merged

fix: node url name #5497

merged 4 commits into from Dec 23, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 22, 2022

Summary

Merge #5496 first!

Updates the proposal information to display the correct node url

...

Changelog

- Added nodeUrl to proposalState store
- Display correct node url

Relevant Issues

closes: #5482

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Dec 22, 2022
@Tuditi Tuditi linked an issue Dec 22, 2022 that may be closed by this pull request
3 tasks
@jeeanribeiro jeeanribeiro merged commit ec4200a into stardust-develop Dec 23, 2022
@jeeanribeiro jeeanribeiro deleted the fix/node-url-name branch December 23, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix incorrect node URL in proposal information pane
2 participants