enhancement: burn nft activity #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkNerdi996
added
type:enhancement
…ent/burn-nft-activity
…ent/burn-nft-activity
3 tasks
nicole-obrien
suggested changes
Jan 11, 2023
There was a problem hiding this comment.
Few changes required:
- On restore burnt NFT details are not being shown just an undefined name
- Rename generate activity functions to better reflect that they are not generating specific functions but generating from specific outputs
- Rename defaultNftId in generateSingleNftActivity as its confusing with the default zeroed nft id
…ent/burn-nft-activity
…ent/burn-nft-activity
nicole-obrien
approved these changes
Jan 15, 2023
Tuditi
pushed a commit
that referenced
this pull request
Jan 17, 2023
* enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Tuditi
added a commit
that referenced
this pull request
Jan 17, 2023
* feat: add governance activity types Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> * chore: remove inputs on activity * feat: generate + display governance activities * feat-mobile: prepare network configuration settings router & init view (#5525) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * refactor: clean settings meta constant * emtpy commit to trigger the checks Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * fix: swap logic order (#5545) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * Update crowdin.yml (#5550) * chore: update files after branch rename (#5551) * chore: make changes for some files * chore: update PR template * chore: add main branches to Snyk CI * chore: update documentation (#5552) * chore: update documentation * empty Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * chore: update `wallet.rs` version (#5555) * chore: update `wallet.rs` version * chore: remove comment * chore: cleanup imports * chore: fix tests * chore: polish governance UI/UX (#5532) * fix: proposals grid spacing * enhancement: adds sorting to proposals * chore: wrap register proposal in a form element * chore: wrap vote for proposal in a form element * enhancement: adds only value UI to SelectorInput * feat: adds NodeInput component * enhancement: adds NodeInput in RegisterProposalPopup * feat: adds disabled state to SliderInput * fix: adds dark mode styling * chore: debounce buttons and add spinners in register proposal and node auth popups * fix: only show text hint in remove proposal popup if event status is commencing or holding * fix: disabled voting options when event is in upcoming or ended phase * fix: adds reactivity to counted votes * enhancement: adds reactivity to ProposalDetailsMenu * Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux * refactor: SliderInput code style * fix: apply suggestions * fix: adds missing semicolon in css * fix: missing display block Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * refactor: minimize `getParticipationOverview` calls (#5533) * fix: use store instead of calling function always * chore: fix linting error * fix: reactive changes to votes counted * fix: update participation overview onMount * refactor: improves code * fix: make changes per PR comments * fix: show 0 value proposals details Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> * feat-mobile: view node information (#5527) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * wip: kickoff node info details * feat-mobile: add node info view * fix: add missing prop * style: polish UI Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * enhancement: governance activity tile * enhancmenet: governance activity details popup * feat: show current vote (#5557) * feat: select current vote * fix: correct background color for selected vote * fix: blue border if selected * refactor: consistent event handling * fix: rerender answer if necessary * change "clicked" to "click" * fix: pr review * fix: improve error handling * fix: correct event name * feat: disable event handler if question is answer is hidden * fix: add optional chaining to toString Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> * fix: add check for reserved tag keywords (#5567) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * feat: pinging badge active vote (#5568) * chore: adds prop classes to PingingBadge and remove positioning classes from it * feat: adds PingingBadge component to ProposalAnswer * chore: remove .ring css selector Co-authored-by: Tuditi <daviddetroch@pm.me> * chore: upgrade `postcss-url` dep (#5553) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: remove acceptance criteria (#5565) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: update translations * enhancement: PR reviews * fix: fix initial voting power increase * fix: submit only once (#5563) * fix: submit only once * refactor: use correct type * fix: two-way binding of values for repeated errors Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> * feat: feature flag platform method (#5560) * feat: adds "isFeatureFlagEnabled" method in platforms * feat: adds example * chore: add method to mock * fix: format electronApi * fix: format capacitorApi * fix: adds brackets wrapping the method code * chore: adds missing types * fix: removes arrow from function * fix * fix: add fetch to default module property Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * fix: removes username and password from NodeAuthRequiredPopup (#5570) * enhancement: burn nft activity (#5526) * enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> * enhancement: update ui * revert: revert capacitor api * fix: fix import * fix: fix random typescript bug * ui: fix alignment Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Tuditi
pushed a commit
that referenced
this pull request
Jan 17, 2023
* enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Tuditi
pushed a commit
that referenced
this pull request
Jan 17, 2023
* enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Tuditi
added a commit
that referenced
this pull request
Jan 17, 2023
* feat: add governance activity types Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> * chore: remove inputs on activity * feat: generate + display governance activities * feat-mobile: prepare network configuration settings router & init view (#5525) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * refactor: clean settings meta constant * emtpy commit to trigger the checks Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * fix: swap logic order (#5545) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * Update crowdin.yml (#5550) * chore: update files after branch rename (#5551) * chore: make changes for some files * chore: update PR template * chore: add main branches to Snyk CI * chore: update documentation (#5552) * chore: update documentation * empty Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * chore: update `wallet.rs` version (#5555) * chore: update `wallet.rs` version * chore: remove comment * chore: cleanup imports * chore: fix tests * chore: polish governance UI/UX (#5532) * fix: proposals grid spacing * enhancement: adds sorting to proposals * chore: wrap register proposal in a form element * chore: wrap vote for proposal in a form element * enhancement: adds only value UI to SelectorInput * feat: adds NodeInput component * enhancement: adds NodeInput in RegisterProposalPopup * feat: adds disabled state to SliderInput * fix: adds dark mode styling * chore: debounce buttons and add spinners in register proposal and node auth popups * fix: only show text hint in remove proposal popup if event status is commencing or holding * fix: disabled voting options when event is in upcoming or ended phase * fix: adds reactivity to counted votes * enhancement: adds reactivity to ProposalDetailsMenu * Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux * refactor: SliderInput code style * fix: apply suggestions * fix: adds missing semicolon in css * fix: missing display block Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * refactor: minimize `getParticipationOverview` calls (#5533) * fix: use store instead of calling function always * chore: fix linting error * fix: reactive changes to votes counted * fix: update participation overview onMount * refactor: improves code * fix: make changes per PR comments * fix: show 0 value proposals details Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> * feat-mobile: view node information (#5527) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * wip: kickoff node info details * feat-mobile: add node info view * fix: add missing prop * style: polish UI Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * enhancement: governance activity tile * enhancmenet: governance activity details popup * feat: show current vote (#5557) * feat: select current vote * fix: correct background color for selected vote * fix: blue border if selected * refactor: consistent event handling * fix: rerender answer if necessary * change "clicked" to "click" * fix: pr review * fix: improve error handling * fix: correct event name * feat: disable event handler if question is answer is hidden * fix: add optional chaining to toString Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> * fix: add check for reserved tag keywords (#5567) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * feat: pinging badge active vote (#5568) * chore: adds prop classes to PingingBadge and remove positioning classes from it * feat: adds PingingBadge component to ProposalAnswer * chore: remove .ring css selector Co-authored-by: Tuditi <daviddetroch@pm.me> * chore: upgrade `postcss-url` dep (#5553) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: remove acceptance criteria (#5565) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: update translations * enhancement: PR reviews * fix: fix initial voting power increase * fix: submit only once (#5563) * fix: submit only once * refactor: use correct type * fix: two-way binding of values for repeated errors Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> * feat: feature flag platform method (#5560) * feat: adds "isFeatureFlagEnabled" method in platforms * feat: adds example * chore: add method to mock * fix: format electronApi * fix: format capacitorApi * fix: adds brackets wrapping the method code * chore: adds missing types * fix: removes arrow from function * fix * fix: add fetch to default module property Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * fix: removes username and password from NodeAuthRequiredPopup (#5570) * enhancement: burn nft activity (#5526) * enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> * enhancement: update ui * revert: revert capacitor api * fix: fix import * fix: fix random typescript bug * ui: fix alignment Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Tuditi
added a commit
that referenced
this pull request
Jan 18, 2023
* feat: add governance activity types Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> * chore: remove inputs on activity * feat: generate + display governance activities * feat-mobile: prepare network configuration settings router & init view (#5525) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * refactor: clean settings meta constant * emtpy commit to trigger the checks Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * fix: swap logic order (#5545) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * Update crowdin.yml (#5550) * chore: update files after branch rename (#5551) * chore: make changes for some files * chore: update PR template * chore: add main branches to Snyk CI * chore: update documentation (#5552) * chore: update documentation * empty Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * chore: update `wallet.rs` version (#5555) * chore: update `wallet.rs` version * chore: remove comment * chore: cleanup imports * chore: fix tests * chore: polish governance UI/UX (#5532) * fix: proposals grid spacing * enhancement: adds sorting to proposals * chore: wrap register proposal in a form element * chore: wrap vote for proposal in a form element * enhancement: adds only value UI to SelectorInput * feat: adds NodeInput component * enhancement: adds NodeInput in RegisterProposalPopup * feat: adds disabled state to SliderInput * fix: adds dark mode styling * chore: debounce buttons and add spinners in register proposal and node auth popups * fix: only show text hint in remove proposal popup if event status is commencing or holding * fix: disabled voting options when event is in upcoming or ended phase * fix: adds reactivity to counted votes * enhancement: adds reactivity to ProposalDetailsMenu * Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux * refactor: SliderInput code style * fix: apply suggestions * fix: adds missing semicolon in css * fix: missing display block Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * refactor: minimize `getParticipationOverview` calls (#5533) * fix: use store instead of calling function always * chore: fix linting error * fix: reactive changes to votes counted * fix: update participation overview onMount * refactor: improves code * fix: make changes per PR comments * fix: show 0 value proposals details Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> * feat-mobile: view node information (#5527) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * wip: kickoff node info details * feat-mobile: add node info view * fix: add missing prop * style: polish UI Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * enhancement: governance activity tile * enhancmenet: governance activity details popup * feat: show current vote (#5557) * feat: select current vote * fix: correct background color for selected vote * fix: blue border if selected * refactor: consistent event handling * fix: rerender answer if necessary * change "clicked" to "click" * fix: pr review * fix: improve error handling * fix: correct event name * feat: disable event handler if question is answer is hidden * fix: add optional chaining to toString Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> * fix: add check for reserved tag keywords (#5567) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * feat: pinging badge active vote (#5568) * chore: adds prop classes to PingingBadge and remove positioning classes from it * feat: adds PingingBadge component to ProposalAnswer * chore: remove .ring css selector Co-authored-by: Tuditi <daviddetroch@pm.me> * chore: upgrade `postcss-url` dep (#5553) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: remove acceptance criteria (#5565) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: update translations * enhancement: PR reviews * fix: fix initial voting power increase * fix: submit only once (#5563) * fix: submit only once * refactor: use correct type * fix: two-way binding of values for repeated errors Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> * feat: feature flag platform method (#5560) * feat: adds "isFeatureFlagEnabled" method in platforms * feat: adds example * chore: add method to mock * fix: format electronApi * fix: format capacitorApi * fix: adds brackets wrapping the method code * chore: adds missing types * fix: removes arrow from function * fix * fix: add fetch to default module property Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * fix: removes username and password from NodeAuthRequiredPopup (#5570) * enhancement: burn nft activity (#5526) * enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> * enhancement: update ui * revert: revert capacitor api * fix: fix import * fix: fix random typescript bug * ui: fix alignment * enhancement: parse governance metadata * enhancement: add start/stop voting activity tile * fix: fix eventId encoding * enhancement: governent activity details popup * enhancement: add proposal name to details popup * fix: fix start/stop voting Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> * refactro: extract helper functions to own file Co-authored-by: Tuditi <Tuditi@users.noreply.github.com> * feat: voting power activities (#5547) * feat: add governance activity types Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> * chore: remove inputs on activity * feat: generate + display governance activities * feat-mobile: prepare network configuration settings router & init view (#5525) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * refactor: clean settings meta constant * emtpy commit to trigger the checks Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * fix: swap logic order (#5545) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * Update crowdin.yml (#5550) * chore: update files after branch rename (#5551) * chore: make changes for some files * chore: update PR template * chore: add main branches to Snyk CI * chore: update documentation (#5552) * chore: update documentation * empty Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * chore: update `wallet.rs` version (#5555) * chore: update `wallet.rs` version * chore: remove comment * chore: cleanup imports * chore: fix tests * chore: polish governance UI/UX (#5532) * fix: proposals grid spacing * enhancement: adds sorting to proposals * chore: wrap register proposal in a form element * chore: wrap vote for proposal in a form element * enhancement: adds only value UI to SelectorInput * feat: adds NodeInput component * enhancement: adds NodeInput in RegisterProposalPopup * feat: adds disabled state to SliderInput * fix: adds dark mode styling * chore: debounce buttons and add spinners in register proposal and node auth popups * fix: only show text hint in remove proposal popup if event status is commencing or holding * fix: disabled voting options when event is in upcoming or ended phase * fix: adds reactivity to counted votes * enhancement: adds reactivity to ProposalDetailsMenu * Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux * refactor: SliderInput code style * fix: apply suggestions * fix: adds missing semicolon in css * fix: missing display block Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * refactor: minimize `getParticipationOverview` calls (#5533) * fix: use store instead of calling function always * chore: fix linting error * fix: reactive changes to votes counted * fix: update participation overview onMount * refactor: improves code * fix: make changes per PR comments * fix: show 0 value proposals details Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Tuditi <daviddetroch@pm.me> * feat-mobile: view node information (#5527) * feat-mobile: kickoff node config settings * feat-mobile: prepare network configuration settings router & move settings files around * fix: function typo * wip: kickoff node info details * feat-mobile: add node info view * fix: add missing prop * style: polish UI Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> * enhancement: governance activity tile * enhancmenet: governance activity details popup * feat: show current vote (#5557) * feat: select current vote * fix: correct background color for selected vote * fix: blue border if selected * refactor: consistent event handling * fix: rerender answer if necessary * change "clicked" to "click" * fix: pr review * fix: improve error handling * fix: correct event name * feat: disable event handler if question is answer is hidden * fix: add optional chaining to toString Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> * fix: add check for reserved tag keywords (#5567) Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> * feat: pinging badge active vote (#5568) * chore: adds prop classes to PingingBadge and remove positioning classes from it * feat: adds PingingBadge component to ProposalAnswer * chore: remove .ring css selector Co-authored-by: Tuditi <daviddetroch@pm.me> * chore: upgrade `postcss-url` dep (#5553) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: remove acceptance criteria (#5565) Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * chore: update translations * enhancement: PR reviews * fix: fix initial voting power increase * fix: submit only once (#5563) * fix: submit only once * refactor: use correct type * fix: two-way binding of values for repeated errors Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> * feat: feature flag platform method (#5560) * feat: adds "isFeatureFlagEnabled" method in platforms * feat: adds example * chore: add method to mock * fix: format electronApi * fix: format capacitorApi * fix: adds brackets wrapping the method code * chore: adds missing types * fix: removes arrow from function * fix * fix: add fetch to default module property Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> * fix: removes username and password from NodeAuthRequiredPopup (#5570) * enhancement: burn nft activity (#5526) * enhancement: calculate if output is burning output * enhancement: fix burn activity * enhancement: remove already classified nft * chore: improve code quality * chore: improve code * fix: burned nfts dont show up in gallery * chore: rename parameter * chore: rename generator functions * enhancement: fix not loaded nfts on account restore + improve performance Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> * enhancement: update ui * revert: revert capacitor api * fix: fix import * fix: fix random typescript bug * ui: fix alignment Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> Co-authored-by: Mark Nardi <mark.nardi@iota.org> Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com> * chore: remove duplicated import * enhancement: add activity after start/stop voting * enhancement: truncat proposalname * fix: fix loading state Co-authored-by: Tuditi <daviddetroch@pm.me> Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org> Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the classification of burning activities for nfts
Changelog
Relevant Issues
Closes #5194
Testing
Platforms
Instructions
...
Checklist