Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show current vote #5557

Merged
merged 13 commits into from Jan 12, 2023
Merged

feat: show current vote #5557

merged 13 commits into from Jan 12, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Jan 11, 2023 •
edited

Summary

Show the current vote of a user.

...

Changelog

- Added setting current vote
- Changed communication between DetailsView<>ProposalAnswer<>ProposalQuestion
- Added UI changes wrt selected and voted for answer

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi linked an issue Jan 11, 2023 that may be closed by this pull request
[Task]: Show current vote #5495
Closed
4 tasks
maxwellmattryan
maxwellmattryan suggested changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just left some minor comments.

packages/desktop/views/dashboard/governance/views/DetailsView.svelte Outdated Show resolved Hide resolved
packages/shared/components/ProposalQuestion.svelte Outdated Show resolved Hide resolved
packages/shared/components/ProposalQuestion.svelte Outdated Show resolved Hide resolved
@maxwellmattryan
Copy link
Contributor

Some observations after testing:

  • The current voted answer is shown, but the indicator icon is missing the pulse animation.
  • It's a bit strange that I can select / de-select the current voted answer whenever the question is collapsed - in the collapsed state it shouldn't be possible to de-select the answer IMO. It looks slightly strange if I expand a question, select a different answer, collapse the question, resulting in the current voted answer looking different from the others.
  • When clicking on a proposal to see its details, the loading of the questions itself takes a noticeably long amount of time plus another noticeably long amount of time to display the current votes.

Those are all relatively small details that will help improve UX, but as of now it is looking really good. Great job 👏

@Tuditi
Copy link
Contributor Author

Tuditi commented Jan 12, 2023

I disabled the possibility to click on an answer when the question is disabled. I added tasks for the other remarks you made ☺️ .

@maxwellmattryan
Copy link
Contributor

Perhaps is out of the scope of this PR just slightly, but one last piece of feedback - if I want to re-vote, with a single changed answer, I have to manually re-select the answers for every question even if they're already selected. I should be able to just select a different answer for only one question and have the "Vote" button become enabled.

maxwellmattryan
maxwellmattryan approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

I added remaining polish tasks in #5546

@maxwellmattryan maxwellmattryan merged commit 8260c4c into develop Jan 12, 2023
@maxwellmattryan maxwellmattryan deleted the feat/show-current-vote branch January 12, 2023 20:32
Tuditi added a commit that referenced this pull request Jan 17, 2023
@Tuditi @jeeanribeiro
feat: show current vote (#5557)
9ffd6a7 
* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Tuditi added a commit that referenced this pull request Jan 17, 2023
@Tuditi @MarkNerdi
@MarkNerdi996 @begonaalvarezd @paul-boegelsack @maxwellmattryan @jeeanribeiro @nicole-obrien
feat: voting power activities (#5547)
929afe2 
* feat: add governance activity types

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>

* chore: remove inputs on activity

* feat: generate + display governance activities

* feat-mobile: prepare network configuration settings router & init view (#5525)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* refactor: clean settings meta constant

* emtpy commit to trigger the checks

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* fix: swap logic order (#5545)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* Update crowdin.yml (#5550)

* chore: update files after branch rename (#5551)

* chore: make changes for some files

* chore: update PR template

* chore: add main branches to Snyk CI

* chore: update documentation (#5552)

* chore: update documentation

* empty

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* chore: update `wallet.rs` version (#5555)

* chore: update `wallet.rs` version

* chore: remove comment

* chore: cleanup imports

* chore: fix tests

* chore: polish governance UI/UX (#5532)

* fix: proposals grid spacing

* enhancement: adds sorting to proposals

* chore: wrap register proposal in a form element

* chore: wrap vote for proposal in a form element

* enhancement: adds only value UI to SelectorInput

* feat: adds NodeInput component

* enhancement: adds NodeInput in RegisterProposalPopup

* feat: adds disabled state to SliderInput

* fix: adds dark mode styling

* chore: debounce buttons and add spinners in register proposal and node auth popups

* fix: only show text hint in remove proposal popup if event status is commencing or holding

* fix: disabled voting options when event is in upcoming or ended phase

* fix: adds reactivity to counted votes

* enhancement: adds reactivity to ProposalDetailsMenu

* Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux

* refactor: SliderInput code style

* fix: apply suggestions

* fix: adds missing semicolon in css

* fix: missing display block

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* refactor: minimize `getParticipationOverview` calls (#5533)

* fix: use store instead of calling function always

* chore: fix linting error

* fix: reactive changes to votes counted

* fix: update participation overview onMount

* refactor: improves code

* fix: make changes per PR comments

* fix: show 0 value proposals details

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* feat-mobile: view node information (#5527)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* wip: kickoff node info details

* feat-mobile: add node info view

* fix: add missing prop

* style: polish UI

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* enhancement: governance activity tile

* enhancmenet: governance activity details popup

* feat: show current vote (#5557)

* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>

* fix: add check for reserved tag keywords (#5567)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* feat: pinging badge active vote (#5568)

* chore: adds prop classes to PingingBadge and remove positioning classes from it

* feat: adds PingingBadge component to ProposalAnswer

* chore: remove .ring css selector

Co-authored-by: Tuditi <daviddetroch@pm.me>

* chore: upgrade `postcss-url` dep (#5553)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: remove acceptance criteria (#5565)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: update translations

* enhancement: PR reviews

* fix: fix initial voting power increase

* fix: submit only once (#5563)

* fix: submit only once

* refactor: use correct type

* fix: two-way binding of values for repeated errors

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* feat: feature flag platform method (#5560)

* feat: adds "isFeatureFlagEnabled" method in platforms

* feat: adds example

* chore: add method to mock

* fix: format electronApi

* fix: format capacitorApi

* fix: adds brackets wrapping the method code

* chore: adds missing types

* fix: removes arrow from function

* fix

* fix: add fetch to default module property

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* fix: removes username and password from NodeAuthRequiredPopup (#5570)

* enhancement: burn nft activity (#5526)

* enhancement: calculate if output is burning output

* enhancement: fix burn activity

* enhancement: remove already classified nft

* chore: improve code quality

* chore: improve code

* fix: burned nfts dont show up in gallery

* chore: rename parameter

* chore: rename generator functions

* enhancement: fix not loaded nfts on account restore + improve performance

Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>

* enhancement: update ui

* revert: revert capacitor api

* fix: fix import

* fix: fix random typescript bug

* ui: fix alignment

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Tuditi added a commit that referenced this pull request Jan 17, 2023
@Tuditi @jeeanribeiro
feat: show current vote (#5557)
ad77d67 
* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Tuditi added a commit that referenced this pull request Jan 17, 2023
@Tuditi @jeeanribeiro
feat: show current vote (#5557)
f5f3b95 
* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Tuditi added a commit that referenced this pull request Jan 17, 2023
@Tuditi @MarkNerdi
@MarkNerdi996 @begonaalvarezd @paul-boegelsack @maxwellmattryan @jeeanribeiro @nicole-obrien
feat: voting power activities (#5547)
900984e 
* feat: add governance activity types

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>

* chore: remove inputs on activity

* feat: generate + display governance activities

* feat-mobile: prepare network configuration settings router & init view (#5525)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* refactor: clean settings meta constant

* emtpy commit to trigger the checks

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* fix: swap logic order (#5545)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* Update crowdin.yml (#5550)

* chore: update files after branch rename (#5551)

* chore: make changes for some files

* chore: update PR template

* chore: add main branches to Snyk CI

* chore: update documentation (#5552)

* chore: update documentation

* empty

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* chore: update `wallet.rs` version (#5555)

* chore: update `wallet.rs` version

* chore: remove comment

* chore: cleanup imports

* chore: fix tests

* chore: polish governance UI/UX (#5532)

* fix: proposals grid spacing

* enhancement: adds sorting to proposals

* chore: wrap register proposal in a form element

* chore: wrap vote for proposal in a form element

* enhancement: adds only value UI to SelectorInput

* feat: adds NodeInput component

* enhancement: adds NodeInput in RegisterProposalPopup

* feat: adds disabled state to SliderInput

* fix: adds dark mode styling

* chore: debounce buttons and add spinners in register proposal and node auth popups

* fix: only show text hint in remove proposal popup if event status is commencing or holding

* fix: disabled voting options when event is in upcoming or ended phase

* fix: adds reactivity to counted votes

* enhancement: adds reactivity to ProposalDetailsMenu

* Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux

* refactor: SliderInput code style

* fix: apply suggestions

* fix: adds missing semicolon in css

* fix: missing display block

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* refactor: minimize `getParticipationOverview` calls (#5533)

* fix: use store instead of calling function always

* chore: fix linting error

* fix: reactive changes to votes counted

* fix: update participation overview onMount

* refactor: improves code

* fix: make changes per PR comments

* fix: show 0 value proposals details

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* feat-mobile: view node information (#5527)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* wip: kickoff node info details

* feat-mobile: add node info view

* fix: add missing prop

* style: polish UI

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* enhancement: governance activity tile

* enhancmenet: governance activity details popup

* feat: show current vote (#5557)

* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>

* fix: add check for reserved tag keywords (#5567)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* feat: pinging badge active vote (#5568)

* chore: adds prop classes to PingingBadge and remove positioning classes from it

* feat: adds PingingBadge component to ProposalAnswer

* chore: remove .ring css selector

Co-authored-by: Tuditi <daviddetroch@pm.me>

* chore: upgrade `postcss-url` dep (#5553)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: remove acceptance criteria (#5565)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: update translations

* enhancement: PR reviews

* fix: fix initial voting power increase

* fix: submit only once (#5563)

* fix: submit only once

* refactor: use correct type

* fix: two-way binding of values for repeated errors

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* feat: feature flag platform method (#5560)

* feat: adds "isFeatureFlagEnabled" method in platforms

* feat: adds example

* chore: add method to mock

* fix: format electronApi

* fix: format capacitorApi

* fix: adds brackets wrapping the method code

* chore: adds missing types

* fix: removes arrow from function

* fix

* fix: add fetch to default module property

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* fix: removes username and password from NodeAuthRequiredPopup (#5570)

* enhancement: burn nft activity (#5526)

* enhancement: calculate if output is burning output

* enhancement: fix burn activity

* enhancement: remove already classified nft

* chore: improve code quality

* chore: improve code

* fix: burned nfts dont show up in gallery

* chore: rename parameter

* chore: rename generator functions

* enhancement: fix not loaded nfts on account restore + improve performance

Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>

* enhancement: update ui

* revert: revert capacitor api

* fix: fix import

* fix: fix random typescript bug

* ui: fix alignment

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Tuditi added a commit that referenced this pull request Jan 18, 2023
@MarkNerdi996 @Tuditi
@MarkNerdi @begonaalvarezd @paul-boegelsack @maxwellmattryan @jeeanribeiro @nicole-obrien
feat: start and stop voting activity (#5602)
be59a66 
* feat: add governance activity types

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>

* chore: remove inputs on activity

* feat: generate + display governance activities

* feat-mobile: prepare network configuration settings router & init view (#5525)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* refactor: clean settings meta constant

* emtpy commit to trigger the checks

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* fix: swap logic order (#5545)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* Update crowdin.yml (#5550)

* chore: update files after branch rename (#5551)

* chore: make changes for some files

* chore: update PR template

* chore: add main branches to Snyk CI

* chore: update documentation (#5552)

* chore: update documentation

* empty

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* chore: update `wallet.rs` version (#5555)

* chore: update `wallet.rs` version

* chore: remove comment

* chore: cleanup imports

* chore: fix tests

* chore: polish governance UI/UX (#5532)

* fix: proposals grid spacing

* enhancement: adds sorting to proposals

* chore: wrap register proposal in a form element

* chore: wrap vote for proposal in a form element

* enhancement: adds only value UI to SelectorInput

* feat: adds NodeInput component

* enhancement: adds NodeInput in RegisterProposalPopup

* feat: adds disabled state to SliderInput

* fix: adds dark mode styling

* chore: debounce buttons and add spinners in register proposal and node auth popups

* fix: only show text hint in remove proposal popup if event status is commencing or holding

* fix: disabled voting options when event is in upcoming or ended phase

* fix: adds reactivity to counted votes

* enhancement: adds reactivity to ProposalDetailsMenu

* Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux

* refactor: SliderInput code style

* fix: apply suggestions

* fix: adds missing semicolon in css

* fix: missing display block

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* refactor: minimize `getParticipationOverview` calls (#5533)

* fix: use store instead of calling function always

* chore: fix linting error

* fix: reactive changes to votes counted

* fix: update participation overview onMount

* refactor: improves code

* fix: make changes per PR comments

* fix: show 0 value proposals details

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* feat-mobile: view node information (#5527)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* wip: kickoff node info details

* feat-mobile: add node info view

* fix: add missing prop

* style: polish UI

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* enhancement: governance activity tile

* enhancmenet: governance activity details popup

* feat: show current vote (#5557)

* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>

* fix: add check for reserved tag keywords (#5567)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* feat: pinging badge active vote (#5568)

* chore: adds prop classes to PingingBadge and remove positioning classes from it

* feat: adds PingingBadge component to ProposalAnswer

* chore: remove .ring css selector

Co-authored-by: Tuditi <daviddetroch@pm.me>

* chore: upgrade `postcss-url` dep (#5553)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: remove acceptance criteria (#5565)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: update translations

* enhancement: PR reviews

* fix: fix initial voting power increase

* fix: submit only once (#5563)

* fix: submit only once

* refactor: use correct type

* fix: two-way binding of values for repeated errors

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* feat: feature flag platform method (#5560)

* feat: adds "isFeatureFlagEnabled" method in platforms

* feat: adds example

* chore: add method to mock

* fix: format electronApi

* fix: format capacitorApi

* fix: adds brackets wrapping the method code

* chore: adds missing types

* fix: removes arrow from function

* fix

* fix: add fetch to default module property

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* fix: removes username and password from NodeAuthRequiredPopup (#5570)

* enhancement: burn nft activity (#5526)

* enhancement: calculate if output is burning output

* enhancement: fix burn activity

* enhancement: remove already classified nft

* chore: improve code quality

* chore: improve code

* fix: burned nfts dont show up in gallery

* chore: rename parameter

* chore: rename generator functions

* enhancement: fix not loaded nfts on account restore + improve performance

Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>

* enhancement: update ui

* revert: revert capacitor api

* fix: fix import

* fix: fix random typescript bug

* ui: fix alignment

* enhancement: parse governance metadata

* enhancement: add start/stop voting activity tile

* fix: fix eventId encoding

* enhancement: governent activity details popup

* enhancement: add proposal name to details popup

* fix: fix start/stop voting

Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>

* refactro: extract helper functions to own file

Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>

* feat: voting power activities (#5547)

* feat: add governance activity types

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>

* chore: remove inputs on activity

* feat: generate + display governance activities

* feat-mobile: prepare network configuration settings router & init view (#5525)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* refactor: clean settings meta constant

* emtpy commit to trigger the checks

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* fix: swap logic order (#5545)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* Update crowdin.yml (#5550)

* chore: update files after branch rename (#5551)

* chore: make changes for some files

* chore: update PR template

* chore: add main branches to Snyk CI

* chore: update documentation (#5552)

* chore: update documentation

* empty

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* chore: update `wallet.rs` version (#5555)

* chore: update `wallet.rs` version

* chore: remove comment

* chore: cleanup imports

* chore: fix tests

* chore: polish governance UI/UX (#5532)

* fix: proposals grid spacing

* enhancement: adds sorting to proposals

* chore: wrap register proposal in a form element

* chore: wrap vote for proposal in a form element

* enhancement: adds only value UI to SelectorInput

* feat: adds NodeInput component

* enhancement: adds NodeInput in RegisterProposalPopup

* feat: adds disabled state to SliderInput

* fix: adds dark mode styling

* chore: debounce buttons and add spinners in register proposal and node auth popups

* fix: only show text hint in remove proposal popup if event status is commencing or holding

* fix: disabled voting options when event is in upcoming or ended phase

* fix: adds reactivity to counted votes

* enhancement: adds reactivity to ProposalDetailsMenu

* Merge branch 'stardust-develop' of github.com:iotaledger/firefly into chore/polish-governance-ui-ux

* refactor: SliderInput code style

* fix: apply suggestions

* fix: adds missing semicolon in css

* fix: missing display block

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* refactor: minimize `getParticipationOverview` calls (#5533)

* fix: use store instead of calling function always

* chore: fix linting error

* fix: reactive changes to votes counted

* fix: update participation overview onMount

* refactor: improves code

* fix: make changes per PR comments

* fix: show 0 value proposals details

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Tuditi <daviddetroch@pm.me>

* feat-mobile: view node information (#5527)

* feat-mobile: kickoff node config settings

* feat-mobile: prepare network configuration settings router & move settings files around

* fix: function typo

* wip: kickoff node info details

* feat-mobile: add node info view

* fix: add missing prop

* style: polish UI

Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>

* enhancement: governance activity tile

* enhancmenet: governance activity details popup

* feat: show current vote (#5557)

* feat: select current vote

* fix: correct background color for selected vote

* fix: blue border if selected

* refactor: consistent event handling

* fix: rerender answer if necessary

* change "clicked" to "click"

* fix: pr review

* fix: improve error handling

* fix: correct event name

* feat: disable event handler if question is answer is hidden

* fix: add optional chaining to toString

Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>

* fix: add check for reserved tag keywords (#5567)

Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>

* feat: pinging badge active vote (#5568)

* chore: adds prop classes to PingingBadge and remove positioning classes from it

* feat: adds PingingBadge component to ProposalAnswer

* chore: remove .ring css selector

Co-authored-by: Tuditi <daviddetroch@pm.me>

* chore: upgrade `postcss-url` dep (#5553)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: remove acceptance criteria (#5565)

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* chore: update translations

* enhancement: PR reviews

* fix: fix initial voting power increase

* fix: submit only once (#5563)

* fix: submit only once

* refactor: use correct type

* fix: two-way binding of values for repeated errors

Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>

* feat: feature flag platform method (#5560)

* feat: adds "isFeatureFlagEnabled" method in platforms

* feat: adds example

* chore: add method to mock

* fix: format electronApi

* fix: format capacitorApi

* fix: adds brackets wrapping the method code

* chore: adds missing types

* fix: removes arrow from function

* fix

* fix: add fetch to default module property

Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>

* fix: removes username and password from NodeAuthRequiredPopup (#5570)

* enhancement: burn nft activity (#5526)

* enhancement: calculate if output is burning output

* enhancement: fix burn activity

* enhancement: remove already classified nft

* chore: improve code quality

* chore: improve code

* fix: burned nfts dont show up in gallery

* chore: rename parameter

* chore: rename generator functions

* enhancement: fix not loaded nfts on account restore + improve performance

Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>

* enhancement: update ui

* revert: revert capacitor api

* fix: fix import

* fix: fix random typescript bug

* ui: fix alignment

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>

* chore: remove duplicated import

* enhancement: add activity after start/stop voting

* enhancement: truncat proposalname

* fix: fix loading state

Co-authored-by: Tuditi <daviddetroch@pm.me>
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
Co-authored-by: Paul Bögelsack <pboegelsack@googlemail.com>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: paul-boegelsack <paul.boegelsack@iota.org>
Co-authored-by: Tuditi <Tuditi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellmattryan maxwellmattryan maxwellmattryan approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

@Tuditi Tuditi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Show current vote
3 participants
@Tuditi @maxwellmattryan @jeeanribeiro