Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add option to add all events from a given node #5967

Merged
merged 29 commits into from Mar 1, 2023
Merged

enhancement: add option to add all events from a given node #5967

merged 29 commits into from Mar 1, 2023

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Feb 23, 2023 •
edited

Summary

Please summarize your changes, describing what they are and why they were made.

⚠️ Do NOT merge until #5966 has been merged!

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

maxwellmattryan and others added 13 commits February 23, 2023 08:35
@maxwellmattryan maxwellmattryan added type:enhancement Enhancement to existing feature status:do-not-merge labels Feb 23, 2023
@maxwellmattryan maxwellmattryan self-assigned this Feb 23, 2023
@maxwellmattryan maxwellmattryan linked an issue Feb 23, 2023 that may be closed by this pull request
[Task]: Add option to add all events from a given node #5769
Closed
5 tasks
@maxwellmattryan maxwellmattryan changed the base branch from develop to enhancement/register-event-for-all-client-options-not-only-primary-nodes-at-login-when-new-node-is-added February 23, 2023 22:04
@maxwellmattryan maxwellmattryan marked this pull request as ready for review February 23, 2023 22:15
MarkNerdi996
MarkNerdi996 previously requested changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job,
1 potential UX and 1 code quality improvement

packages/desktop/components/popups/AddProposalPopup.svelte Show resolved Hide resolved
packages/desktop/components/popups/AddProposalPopup.svelte Outdated Show resolved Hide resolved
Base automatically changed from enhancement/register-event-for-all-client-options-not-only-primary-nodes-at-login-when-new-node-is-added to develop March 1, 2023 09:12
nicole-obrien and others added 3 commits March 1, 2023 09:16
@nicole-obrien
Merge remote-tracking branch 'origin/enhancement/register-event-for-a…
cc1ac16 
…ll-client-options-not-only-primary-nodes-at-login-when-new-node-is-added' into enhancement/add-option-to-add-all-events-from-a-given-node
@nicole-obrien
Merge remote-tracking branch 'origin/develop' into enhancement/add-op…
49bcf42 
…tion-to-add-all-events-from-a-given-node
@MarkNerdi996
chore: refactor successmessage
fedfd4d
@nicole-obrien nicole-obrien merged commit 3adc2e2 into develop Mar 1, 2023
@nicole-obrien nicole-obrien deleted the enhancement/add-option-to-add-all-events-from-a-given-node branch March 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicole-obrien nicole-obrien nicole-obrien approved these changes

@MarkNerdi996 MarkNerdi996 MarkNerdi996 left review comments

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@maxwellmattryan maxwellmattryan

Labels
type:enhancement Enhancement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add option to add all events from a given node
3 participants
@maxwellmattryan @nicole-obrien @MarkNerdi996