enhancement: add option to add all events from a given node

packages/desktop/components/popups/AddProposalPopup.svelte

@@ -21,10 +21,11 @@
     let nodeInput: NodeInput
     let nodeInputError: string
     let isBusy = false
-    let toAllAccounts = false
+    let isRegisteringAllProposals = false
+    let isAddingForAllAccounts = false
 
     $: isEditMode = !!initialEventId && !!initialNodeUrl
-    $: disabled = !eventId || !nodeUrl || isBusy
+    $: disabled = isBusy || !nodeUrl || (!isRegisteringAllProposals && !eventId)
     $: eventId = inputtedEventId?.trim()
 
     function onCancelClick(): void {
@@ -34,7 +35,10 @@
     async function onSubmit(): Promise<void> {
         try {
             isBusy = true
-            await Promise.all([validateEventId(!toAllAccounts && !isEditMode), nodeInput?.validate()])
+            await Promise.all([
+                !isRegisteringAllProposals && validateEventId(!isAddingForAllAccounts && !isEditMode),
+                nodeInput?.validate(),
+            ])
             await registerParticipationWrapper()
             isBusy = false
         } catch (err) {
@@ -74,28 +78,34 @@
     async function registerParticipationWrapper(auth?: Auth): Promise<void> {
         const options = {
             node: { url: nodeUrl, auth },
-            eventsToRegister: [eventId],
+            eventsToRegister: isRegisteringAllProposals ? [] : [eventId],
         }
-        const accounts = toAllAccounts ? $activeAccounts : [$selectedAccount]
+        const accounts = isAddingForAllAccounts ? $activeAccounts : [$selectedAccount]
         await registerProposalsForAccounts(options, accounts)
-        const successMessage = isEditMode
-            ? localize('views.governance.proposals.successEdit')
-            : localize('views.governance.proposals.' + (toAllAccounts ? 'successAddAll' : 'successAdd'))
         showAppNotification({
             type: 'success',
-            message: successMessage,
+            message: generateSuccessMessage(),
             alert: true,
         })
         closePopup()
     }
 
+    function generateSuccessMessage(): string {
+        if (isEditMode) {
+            return localize('views.governance.proposals.successEdit')
+        } else {
+            return localize(`views.governance.proposals.${isAddingForAllAccounts ? 'successAddAll' : 'successAdd'}`, {
+                values: { numberOfProposals: isRegisteringAllProposals ? 'other' : 'one' },
+            })
+        }
+    }
+
     async function validateEventId(checkIfAlreadyRegistered: boolean): Promise<void> {
         const startsWith0x = eventId?.substring(0, 2) === '0x'
         if (!startsWith0x) {
             eventIdError = localize('error.eventId.doesNotStartWith0x')
             return Promise.reject(eventIdError)
         }
-
         const hexLength = eventId?.substring(2)?.length
         const has64Length = hexLength === 64
         if (!has64Length) {
@@ -115,16 +125,19 @@
     >
     <Text fontSize="15">{localize(`popups.${isEditMode ? 'editProposal' : 'addProposal'}.body`)}</Text>
     <div class="flex flex-col w-full space-y-4 mt-4">
+        <NodeInput bind:this={nodeInput} bind:nodeUrl bind:error={nodeInputError} />
+        {#if !isEditMode}
+            <Checkbox label="Add all proposals on this node" bind:checked={isRegisteringAllProposals} />
+        {/if}
         <TextInput
             bind:value={inputtedEventId}
             bind:error={eventIdError}
+            disabled={isRegisteringAllProposals || isEditMode}
             placeholder={localize('views.governance.details.proposalInformation.eventId')}
             label={localize('views.governance.details.proposalInformation.eventId')}
-            disabled={isEditMode}
         />
-        <NodeInput bind:this={nodeInput} bind:nodeUrl bind:error={nodeInputError} />
         {#if !isEditMode}
-            <Checkbox label={localize('popups.addProposal.addToAllAccounts')} bind:checked={toAllAccounts} />
+            <Checkbox label={localize('popups.addProposal.addToAllAccounts')} bind:checked={isAddingForAllAccounts} />
         {/if}
     </div>
     <div class="flex w-full space-x-4 mt-6">

packages/shared/locales/en.json

@@ -586,8 +586,8 @@
                 "title": "Proposals",
                 "voted": "Voted",
                 "successEdit": "Proposal successfully edited",
-                "successAdd": "Proposal successfully added",
-                "successAddAll": "Proposal successfully added to all accounts",
+                "successAdd": "{numberOfProposals, select, one {Proposal} other {Proposals}} successfully added",
+                "successAddAll": "{numberOfProposals, select, one {Proposal} other {Proposals}} successfully added to all accounts",
                 "successRemove": "Proposal successfully removed",
                 "emptyTitle": "No proposals"
             },