Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove web3 dependency #7044

Merged
merged 14 commits into from
Jul 4, 2023
Merged

chore: Remove web3 dependency #7044

merged 14 commits into from
Jul 4, 2023

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Jun 26, 2023 •
edited
Loading

Summary

Removed the web3 dependency and reverted adding of EVM support

Resolves #7032

Changelog

  • Reverted EVM support commit
  • Resolved conflicts and build errors
  • Tested basic wallet features on Desktop

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Check the gas estimation state. Does it need updates ?

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@msarcev msarcev marked this pull request as draft June 26, 2023 14:52
begonaalvarezd
begonaalvarezd requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amaaazing work 💪🏼
The PR is only drafted but just wanted to add some comment to speed up the review process
Left some minor comments, but the cleanup looks amazing 💪🏼

packages/shared/lib/core/network/interfaces/persisted-network.interface.ts Show resolved Hide resolved
packages/shared/lib/core/layer-2/utils/getDestinationNetworkFromAddress.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/layer-2/utils/getLayer2NetworkFromAddress.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/utils/getDefaultPersistedNetwork.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/stores/selected-connected-chain-index.store.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/interfaces/chain-metadata.interface.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/stores/network.store.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/utils/getNetworkId.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/utils/isEvmChain.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/utils/isIscpChain.ts Outdated Show resolved Hide resolved
@msarcev msarcev marked this pull request as ready for review July 3, 2023 10:15
@begonaalvarezd begonaalvarezd self-requested a review July 3, 2023 12:50
@msarcev msarcev requested a review from marc2332 July 3, 2023 18:10
begonaalvarezd
begonaalvarezd approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🚀

packages/shared/components/molecules/AssetIcon.svelte Outdated Show resolved Hide resolved
@msarcev msarcev force-pushed the chore/remove-web3-dep branch 2 times, most recently from 0651b64 to ad8cdfa Compare July 4, 2023 15:54
msarcev and others added 13 commits July 4, 2023 17:58
@msarcev
chore(cleanup): Remove actuall web3 dependency from package.json
43f7781
@msarcev
chore: Revert commit and resolve conflicts
8750ea0 
Revert "feat: add ISCP/EVM network support (#6634)"

This reverts commit 9232316.

 Conflicts:
	packages/desktop/components/NetworkCard.svelte
	packages/desktop/components/drawers/network-config/drawers/ChainDepositAddressDrawer.svelte
	packages/desktop/components/drawers/network-config/drawers/ConnectedChainsDrawer.svelte
	packages/desktop/components/drawers/network-config/drawers/components/AddIscpChainForm.svelte
	packages/shared/lib/core/network/classes/iscp-chain.class.ts
	packages/shared/lib/core/network/classes/stardust-network.class.ts
	packages/shared/lib/core/network/constants/default-chain-configurations.constant.ts
	packages/shared/lib/core/network/interfaces/chain-configuration.interface.ts
	packages/shared/lib/core/network/interfaces/chain.interface.ts
	packages/shared/lib/core/network/interfaces/index.ts
	packages/shared/lib/core/network/interfaces/network.interface.ts
	packages/shared/lib/core/network/stores/index.ts
	packages/shared/lib/core/network/stores/network.store.ts
	packages/shared/lib/core/network/utils/getDefaultPersistedNetwork.ts
	packages/shared/lib/core/profile/actions/active-profile/checkAndUpdateActiveProfileNetwork.ts
	packages/shared/package.json
	yarn.lock
@msarcev
chore: Fix imports and build errors after revert and conflicts
a74506a
@msarcev
chore: Yarn lock
fe61edb
@msarcev
chore: Resolve web3 import errors (layer-2) and remove unused code
282f0af
@msarcev
chore: Resolve PR feedback issues
4e7aab1
@msarcev
chore(remove web3): Remove Evm chain metadata type
22910ce
@msarcev
chore: Add profile migration (14) for chainConfigurations -> chains key
11e77e9
@msarcev
chore: Fix AssetIcon issues with removed network type
701de5e
@msarcev
chore: Move the profile migration to V13, Cleanup unused code
87b62f7
@msarcev
chore: Fix import error
4261c41
@begonaalvarezd @msarcev
Update packages/shared/components/molecules/AssetIcon.svelte
2c71e4b
@msarcev
chore: Improve naming in migration
527af67
@begonaalvarezd begonaalvarezd merged commit 2bc503e into develop Jul 4, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/remove-web3-dep branch July 4, 2023 16:04
@begonaalvarezd begonaalvarezd mentioned this pull request Jul 5, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 marc2332 approved these changes

@brancoder brancoder Awaiting requested review from brancoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup develop branch: Remove web3 dependency
3 participants
@msarcev @begonaalvarezd @marc2332