fix: L2 transaction metadata decoding #7124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f github.com:iotaledger/firefly into fix/L2-transaction-metadata-decoding
marc2332
approved these changes
Jul 7, 2023
…f github.com:iotaledger/firefly into fix/L2-transaction-metadata-decoding
3 tasks
begonaalvarezd
added a commit
that referenced
this pull request
Jul 13, 2023
* fix: L2 transaction metadata decoding * fix: test with new parse layer 2 metadata * perf: rename parseLayer2MetadataForTransferV1 * perf: modify the order between parse versions * feat: add comments * perf: unify parse layer versions in parseLayer2MetadataForTransfer --------- Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>
10 tasks
begonaalvarezd
added a commit
that referenced
this pull request
Jul 18, 2023
* revert: undo cache deposit address (#7137) * fix: comment (#7142) * chore: bump version to 2.1.4-alpha-1 (#7143) * fix: claiming smr (#6924) * fix: use helper functions instead of checking if store variable exists * chore: fix strict type checking * feat: enhance message in error log * fix: use isMobile helper function * chore: add optional chaining * fix: center receive address button (#7171) * fix: L2 transaction metadata decoding (#7124) * fix: L2 transaction metadata decoding * fix: test with new parse layer 2 metadata * perf: rename parseLayer2MetadataForTransferV1 * perf: modify the order between parse versions * feat: add comments * perf: unify parse layer versions in parseLayer2MetadataForTransfer --------- Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> * fix: crash in activity filters (#7184) * fix: missing async from activity generation * fix: amount filter * perf: add AliasActivity type * perf: improve status filter * fix: test --------- Co-authored-by: cpl121 <cpeon@boxfish.studio> * feat: disable auto update in windows * chore: bump version to 2.1.4-beta-1 * chore: bump version to 2.1.4 --------- Co-authored-by: cpl121 <100352899+cpl121@users.noreply.github.com> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> Co-authored-by: Marc Espín <mespinsanz@gmail.com> Co-authored-by: cpl121 <cpeon@boxfish.studio>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7110
Summary
Modify the decode to parse the metadadata of l2 transactions. The old version is tried first, and if an error is received, the new version is tried.
Changelog
Testing
Platforms
Instructions
Base Token,Native TokenorNFTmetadatafield has the data correctly parsedExample with Base Token Tx
Checklist