Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve account and profile name validation #744

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

obany
Copy link
Contributor

@obany obany commented Mar 25, 2021

Description of change

Improves the robustness of account and profile name validation.
Also fixes the getInitials when there were runs of whitespace in the name.

Links to any relevant issues

Fixes #296 #649 #719

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Tested on windows with lots of different account names with odd characters, emojis, whitespace etc

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 25, 2021 16:10
Co-authored-by: Rajiv Shah <rajivshah1@icloud.com>
@begonaalvarezd begonaalvarezd merged commit 6fee3b4 into develop Mar 29, 2021
@begonaalvarezd begonaalvarezd deleted the fix/profile-account-name-validation branch March 29, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace as account name leads to app freeze
3 participants