feat: add fiat currency conversion on the amount field #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obany
suggested changes
Mar 31, 2021
| @@ -100,7 +116,7 @@ | |||
| <amount-input class:disabled class="relative block {classes}" on:keydown={handleKey}> | |||
| <Input | |||
| {error} | |||
| label={label || locale('general.amount')} | |||
| label={fiatAmount ? `${fiatAmount} ${profileCurrency}` : label || locale('general.amount')} | |||
There was a problem hiding this comment.
This would probably be better as {fiatAmount !== null otherwise it doesn't show when the amount is zero. e.g. 111i still says Amount
cvarley100
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add fiat currency conversion on the amount field
Links to any relevant issues
Related to #763 (not sure we will implement sending fiat directly).
Type of change
How the change has been tested
Electron Linux
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.