chore: Simplify path management #7946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc2332
changed the base branch from
feat/profile-centric-wallet-file-scheme
to
chore/adapt-to-sdk-changes
marc2332
changed the base branch from
chore/adapt-to-sdk-changes
to
chore/clean-up-2.0-comments
marc2332
changed the base branch from
chore/clean-up-2.0-comments
to
chore/adapt-to-sdk-changes
…allet-file-scheme
…plify-path-management
marc2332
changed the base branch from
chore/adapt-to-sdk-changes
to
feat/profile-centric-wallet-file-scheme
…allet-file-scheme
…plify-path-management
This was referenced Feb 1, 2024
Base automatically changed from
feat/profile-centric-wallet-file-scheme
to
develop-iota2.0
February 1, 2024 17:47
begonaalvarezd
requested changes
Feb 6, 2024
packages/shared/lib/core/profile/actions/active-profile/migrateStrongholdFromActiveProfile.ts
Outdated
Show resolved
Hide resolved
…ve constant namings
begonaalvarezd
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7942Closes #7401
This groups all the
getPath/getStoragePathkind of functions in a single class. It was getting to a point where they were too many as I have added a few more in #7942. Now, it's easier to maintain and use