Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update account to wallet in locales #7961

Merged
merged 62 commits into from
Feb 7, 2024

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Feb 1, 2024

Depends on #7946
Closes #7837

Update account to wallet in locales, and also removed outdated

I have left intact the ones related to shimmer rewards for when the time comes

@begonaalvarezd begonaalvarezd linked an issue Feb 5, 2024 that may be closed by this pull request
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still has debris 🙏

  • hideAccount line 819, 830 and 834
  • sendingFromStakedAccount line 930
  • sendingFromStakedAccountBelowMinReward line 931
  • singleAccountGuide line 1056
  • addAccount line 1312
  • moveFundsBetweenAccounts line 1451
  • noAccounts line 1511
  • loadingAccounts line 1512
  • syncingAccounts line 1536
  • noToAccount line 1912

Base automatically changed from chore/simplify-path-management to develop-iota2.0 February 6, 2024 11:04
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ just conflicts!

@begonaalvarezd begonaalvarezd merged commit 8d92527 into develop-iota2.0 Feb 7, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-account-to-wallet-locales branch February 7, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update account to wallet locales
3 participants