Rewrite ConflictDAG #2606
Draft
Rewrite ConflictDAG #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoog
changed the title
…o feat/rewrite-conflictdag-with-voting
piotrm50
force-pushed
the
feat/rewrite-conflictdag-with-voting
branch
from
91372a8
to
bbab455
Compare
…/rewrite-conflictdag-with-voting
- introduced dedicated ConflictDAG interface package - moved implementation to v1 package - removed old ConflictDAG package - started adding generic test framework
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func (f *WeightedSetTestFramework) CreateID(alias string, optWeight ...int64) identity.ID { | ||
| validatorID, exists := f.identitiesByAlias[alias] |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
…ictdag-with-voting
…ictdag-with-voting
…aledger/goshimmer into feat/rewrite-conflictdag-with-voting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR merges several different components into a singular streamlined framework for creating, tracking and managing conflicts (and votes on these conflicts).
In the current code base, we have a lot of different components that interact with Conflicts, and synchronizing these components in the context of multi-threading has proven to be a bit hard to achieve, simply because these components do not share access to a common mutex.
This PR aims to change this by merging all components that currently handle Conflicts into a singular streamlined API. This will not only allow us to de-duplicate a lot of code but we can also use the same caches and data structures for all involved parts.
Type of change
Change checklist