dRNG integration test #408
Conversation
| @@ -15,6 +15,9 @@ jobs: | |||
| - name: Build GoShimmer image | |||
| run: docker build -t iotaledger/goshimmer . | |||
|
|
|||
| - name: Pull drand image | |||
There was a problem hiding this comment.
The image should also be pulled in runTests.sh
| @@ -69,25 +69,49 @@ func (d *DockerContainer) CreateGoShimmerEntryNode(name string, seed string) err | |||
| } | |||
|
|
|||
| // CreateGoShimmerPeer creates a new container with the GoShimmer peer's configuration. | |||
| func (d *DockerContainer) CreateGoShimmerPeer(name string, seed string, entryNodeHost string, entryNodePublicKey string, bootstrap bool) error { | |||
| func (d *DockerContainer) CreateGoShimmerPeer(conf GoShimmerConfig) error { | |||
| distKey []byte | ||
| } | ||
|
|
||
| // newDRNGNetwork returns a Network instance, creates its underlying Docker network and adds the tester container to the network. |
| } | ||
| } | ||
|
|
||
| conf := GoShimmerConfig{ |
| func (n *DRNGNetwork) CreatePeer(c GoShimmerConfig, publicKey hive_ed25519.PublicKey) (*Peer, error) { | ||
| name := n.network.namePrefix(fmt.Sprintf("%s%d", containerNameReplica, len(n.network.peers))) | ||
|
|
||
| conf := c |
|
|
||
| for i := dkgMaxTries; i > 0; i-- { | ||
|
|
||
| //var dkey *drand.DistKeyResponse |
There was a problem hiding this comment.
remove the comment and newlines to make it more readable
| } | ||
|
|
||
| // wait until containers are fully started | ||
| time.Sleep(60 * time.Second) |
There was a problem hiding this comment.
Maybe say why these additional 60 seconds waiting are necessary? It also waits already in WaitForDKG so more explanation would be nice :)
| if drngCommittee != "" { | ||
| drngCommittee += fmt.Sprintf(",") | ||
| } | ||
| drngCommittee += fmt.Sprintf("%s", base58.Encode(pubKeys[i][:])) |
There was a problem hiding this comment.
simplify to
| drngCommittee += fmt.Sprintf("%s", base58.Encode(pubKeys[i][:])) | |
| drngCommittee += pubKeys[i].String() |
|
|
||
| // wait until peers are fully started and connected | ||
| time.Sleep(1 * time.Second) | ||
| err = drng.network.WaitForAutopeering(3) |
There was a problem hiding this comment.
Why set minimumNeighbors here hardcoded? I think it should be a parameter to the function
| for _, peer := range drng.Peers() { | ||
| resp, err := peer.GetRandomness() | ||
| require.NoError(t, err) | ||
| log.Println(resp) |
There was a problem hiding this comment.
This should use t.Log and use the String() function or extract the parameters you want/need to see to avoid a cryptic output like this:
2020/05/06 13:49:11 &{7 2020-05-06 13:49:11.030803713 +0000 UTC [191 58 172 186 178 90 43 238 162 122 248 194 214 41 24 132 189 41 200 84 8 42 129 210 168 182 144 176 17 14 80 185 176 171 79 130 188 245 43 195 168 221 210 24 213 131 127 110 79 115 190 192 233 139 136 152 214 66 25 89 85 145 56 24] }
Description of change
This PR adds the integration test for the dRNG. It also refactors the creation of a peer docker container by adding a GoShimmerConfig struct.