Fix duplicated SignatureUnlocks with Ledger Nano #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
force-pushed
the
ledgernano-fix
branch
from
472503b
to
385d560
Compare
Thoralf-M
changed the title
samuel-rufi
previously approved these changes
Jul 14, 2022
Thoralf-M
force-pushed
the
ledgernano-fix
branch
from
d729cd3
to
e5715bd
Compare
thibault-martinez
approved these changes
Jul 15, 2022
samuel-rufi
approved these changes
Jul 17, 2022
cycraig
pushed a commit
to cycraig/iota.rs-wasm
that referenced
this pull request
Aug 12, 2022
* Review and update Bee content * Review suggestions and corrections added. * Added diataxis keywords * Apply suggestions from code review Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com> Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com> Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com>
cycraig
pushed a commit
to cycraig/iota.rs-wasm
that referenced
this pull request
Aug 12, 2022
* Build dashboard into Docker image (iotaledger#1147) * Lower network log level (iotaledger#1148) * Docs - Minor edits Applying Style Guide and Diataxis (iotaledger#1123) * Review and update Bee content * Review suggestions and corrections added. * Added diataxis keywords * Apply suggestions from code review Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com> Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com> Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com> * Fix missing `.git` folder (iotaledger#1153) * Avoid unbounded `RwLock` guards in `PeerManager` (iotaledger#1139) * avoid unbounded `RwLock` guards * restrict `get_map` function argument to `FnOnce` * Fix API response addressType (iotaledger#1167) * Test equality of JSON and TOML config files (iotaledger#1164) * Test equality of JSON and TOML config files * implement `PartialEq` for `NodeConfigBuilder` * make the `PartialEq` implementation less error prone * Fix test Co-authored-by: Christian Poveda <christian.poveda@iota.org> * Emit better warning when parsing snapshot header fails (iotaledger#1166) * Emit better warning when parsing snapshot header fails * Update `CHANGELOG.md` * Embed error * Use maximum to find furthest neighbor (iotaledger#1173) * Use maximum to find furthest neighbor * Remove now partly wrong note * Strip symbols from production binary (rust >= 1.59) (iotaledger#1175) * Update workflow branches (iotaledger#1172) * Make Rust `beta` and `nightly` experimental (iotaledger#1160) * Make Rust `beta` and `nightly` experimental * Improve PR template * Two separate matrices * Constrain `docs`, `licenses`, and `udeps` runs * Allow failures in `no_std` for `beta` and `nightly` * Further improvements * Full matrix * Fix CI * Run clippy on `stable` and make `beta` optional * Fix `no_std` * try formatting * Test name * Test * f * Pretty please * Test * Make all pretty * Fix * Change order of matrix * Spaces * Free the bird * Clarify Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com> Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com> * Temporarily fix CI by downgrading to `windows-2019` (iotaledger#1177) * Get rid of `experimental` * Automatically cancel older runs * Test `jq` on all plattforms * Also limit doc builds * Revert names * Temporarily switch back to `windows-2019` More information: https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/ * More robust windows detection * Fix Co-authored-by: Jochen Görtler <grtlr@users.noreply.github.com> Co-authored-by: charlesthompson3 <74603461+charlesthompson3@users.noreply.github.com> Co-authored-by: Lucas Tortora <85233773+lucas-tortora@users.noreply.github.com> Co-authored-by: Christian Poveda <31802960+pvdrz@users.noreply.github.com> Co-authored-by: Christian Poveda <christian.poveda@iota.org> Co-authored-by: /alex/ <alexander.schmidt@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fix duplicated SignatureUnlocks with Ledger Nano
Type of change
How the change has been tested
Wallet.rs example
Change checklist