Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle: Fix undefined behavior #2

Merged
merged 3 commits into from
Jan 27, 2020
Merged

bundle: Fix undefined behavior #2

merged 3 commits into from
Jan 27, 2020

Conversation

howjmay
Copy link
Member

@howjmay howjmay commented Jan 14, 2020

When transaction is equals to NULL, then it would cause undefine
behavior. See the description in C99 7.1.4

@howjmay howjmay requested a review from a team as a code owner January 14, 2020 07:29
@thibault-martinez thibault-martinez mentioned this pull request Jan 14, 2020
Closed
thibault-martinez
thibault-martinez requested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the prototype in bundle.h as well.

@thibault-martinez thibault-martinez changed the title fix: Fix undefine behavior bundle: Fix undefined behavior Jan 14, 2020
@howjmay
fix: Fix undefine behavior
16f29b3 
When transaction is equals to NULL, then it would cause undefine
behavior. See the description in C99 7.1.4
@P1robot
Copy link

P1robot commented Jan 24, 2020

Automated benchmark results (pass #0): passed

concurrency: 32
requests per second: 6160
concurrency: 128
requests per second: 7641
concurrency: 512
requests per second: 4685
concurrency: 1024
requests per second: 4006

@oopsmonk oopsmonk merged commit e97da0f into iotaledger:master Jan 27, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oopsmonk oopsmonk oopsmonk approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howjmay @P1robot @oopsmonk @thibault-martinez