Make PearlDiver threads configurable

[CodeMonkeySteve]

Description

Add configuration variable for the number of PoW threads, for manual control.

Fixes #1016

Type of change

• Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Deployed to production IOTA node, verified specified number of threads were used by CPU load.

Checklist:

• My code follows the style guidelines for this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation (where?)
• New and existing unit tests pass locally with my changes

[GalRogozinski]

Hey @CodeMonkeySteve,

Thanks for the PR!
The reason it wasn't merged until now is because it has a conflict. You are using the old configuration design. By looking at the dates I see you probably didn't update your local dev branch since #910
was merged since August 16.

If you decide to do the neccessary changes, please also create a new PearlDiverConfig interface.

[GalRogozinski]

Hey @CodeMonkeySteve,

Thanks for the PR!
The reason it wasn't merged until now is because it has a conflict. You are using the old configuration design. By looking at the dates I see you probably didn't update your local dev branch since #910
was merged since August 16.

If you decide to do the neccessary changes, please also create a new PearlDiverConfig interface.

[GalRogozinski]

Hey @CodeMonkeySteve,

Thanks for the PR!
The reason it wasn't merged until now is because it has a conflict. You are using the old configuration design. By looking at the dates I see you probably didn't update your local dev branch because #910
was merged since August 16.

If you decide to do the neccessary changes, please also create a new PearlDiverConfig interface.

[CodeMonkeySteve]

I added the PearlDiver config, mimicking the other config, but there doesn't seem to be any effect from setting POW_THREADS in the INI file. Am I missing something? Is there something more needed for INI support? Has the format of that file changed?

Any insight would be greatly appreciated (I am not really a Java developer, as you may have noticed).

[GalRogozinski]

Not bad :-)

Do the changes and try the INI file again :-)

[GalRogozinski]

change to setPowThreads

Suggested change

	protected void setPoWThreads(int powThreads) {
	protected void setPowThreads(int powThreads) {

Jackson knows how to translate the name to snake_case. This is why ini wasn't working

[CodeMonkeySteve]

Ah, thanks so much, that fixed it.

[GalRogozinski]

I prefer PowConfig

[CodeMonkeySteve]

Er, you originally asked for PearlDiverConfig. I think that's more appropriate, as there may be other config fields added later.

[GalRogozinski]

👍

[GalRogozinski]

Great!

[jakubcech]

Awesome stuff, thank you @CodeMonkeySteve!

[CodeMonkeySteve]

Happy to help. It's also in my own best interest, as I'm creating >10k transactions per day, so I need to make use of all the CPU cores I have.