New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Dockerfile to source java and maven from Docker Hub instead of downloading it from upstream #929

Merged
merged 1 commit into from Aug 12, 2018

Conversation

Projects
None yet
3 participants
@geminoz
Contributor

geminoz commented Aug 10, 2018

Description

Changed Dockerfile to source java and maven from precompiled docker containers. Fixes #927

The Dockerfiles for the intermediate containers used to build IRI are here: https://github.com/iotaledger/ci-containers

However note the java and maven docker hub containers are currently sourced from a third party Docker Hub repo (iotacafe, I am the repo owner and sole admin) and they should be moved to the iotaledger docker hub organisation for clarity and transparency.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

  • I have pushed the Dockerfiles for java and maven as sourced from the Docker Hub iotacafe repos here: and managed to compile IRI 1.5.3 from the dev branch no problem. The container size is 642MB vs 638MB using the previous Dockerfile. This is slightly unexpected however it is a trivial issue, there probably are files that are not being removed compared to the previous Dockerfile workflow.

  • The 1.5.3 built from this Dockerfile is now running on a mainnet node and seems to be working just fine.

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
Changed Dockerfile to source java and maven from precompiled docker c…
…ontainers. Fixes #927 however the java and maven containers should be moved to the iotaledger docker hub organisation for clarity
@geminoz

This comment has been minimized.

Show comment
Hide comment
@geminoz

geminoz Aug 10, 2018

Contributor

I would like to ping @nuriel77 @ahab94 @zoran above IF members for comments

Contributor

geminoz commented Aug 10, 2018

I would like to ping @nuriel77 @ahab94 @zoran above IF members for comments

@GalRogozinski GalRogozinski self-requested a review Aug 12, 2018

@GalRogozinski GalRogozinski merged commit 8c07de7 into iotaledger:dev Aug 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment