This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Improved Dockerfile to source java and maven from Docker Hub instead of downloading it from upstream #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainers. Fixes #927 however the java and maven containers should be moved to the iotaledger docker hub organisation for clarity
nuriel77
approved these changes
Aug 10, 2018
GalRogozinski
approved these changes
Aug 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed Dockerfile to source java and maven from precompiled docker containers. Fixes #927
The Dockerfiles for the intermediate containers used to build IRI are here: https://github.com/iotaledger/ci-containers
However note the java and maven docker hub containers are currently sourced from a third party Docker Hub repo (iotacafe, I am the repo owner and sole admin) and they should be moved to the iotaledger docker hub organisation for clarity and transparency.
Type of change
How Has This Been Tested?
I have pushed the Dockerfiles for java and maven as sourced from the Docker Hub iotacafe repos here: and managed to compile IRI 1.5.3 from the dev branch no problem. The container size is 642MB vs 638MB using the previous Dockerfile. This is slightly unexpected however it is a trivial issue, there probably are files that are not being removed compared to the previous Dockerfile workflow.
The 1.5.3 built from this Dockerfile is now running on a mainnet node and seems to be working just fine.
Checklist: