This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
Update c bindings, add new functions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semenov-vladyslav
suggested changes
Nov 11, 2020
kwek20
reviewed
Dec 2, 2020
semenov-vladyslav
suggested changes
Dec 8, 2020
| use iota::client::bytes_to_trytes; | ||
|
|
||
| #[no_mangle] | ||
| pub extern "C" fn address_from_string(c_addr: *const c_char) -> *const Address { |
There was a problem hiding this comment.
This is a nice function in general, it's going to be used in other bindings. Maybe move the impl to the main crate?
There was a problem hiding this comment.
Yeah I think that's a good idea, i'll do that before push
Signed-off-by: DyrellC <dyrell.chapman@iota.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updating c bindings to include tagged and signed packets on the subscriber end, as well as a couple utility functions for usability (like converting string link representation to proper streams Address object through bindings).
Type of change
How the change has been tested
I have run each function through modifications of the main.c file, and confirmed they work when pulled into golang
Change checklist