Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-compile for mobile devices #462

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Fix cross-compile for mobile devices #462

merged 5 commits into from
Nov 15, 2022

Conversation

samuel-rufi
Copy link
Member

@samuel-rufi samuel-rufi commented Nov 14, 2022 •
edited

Description of change

This PR aims to fix the cross-compilation issues described in #460.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

  • cross-compilation if the targets works without errors
  • compiling to Linux/macOS continues to run fine

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Thoralf-M
Thoralf-M requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry

@samuel-rufi samuel-rufi changed the title Support android target Fix cross-compile for mobile devices Nov 14, 2022
@thibault-martinez thibault-martinez merged commit cc727cf into iotaledger:dev Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuel-rufi @thibault-martinez @Thoralf-M