Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Deeplinking migration #1256

Closed
wants to merge 15 commits into from

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Apr 3, 2019

Description

To be reviewed after #1168
Related PR: #1143

Type of change

  • Enhancement

How Has This Been Tested?

  • Manually tested iOS (debug)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@laumair laumair added C - Mobile C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this E - Functional Epic - Relating to how a feature works labels Apr 3, 2019
@rajivshah3
Copy link
Member

rajivshah3 commented Apr 5, 2019

@laumair could you try reverting the shrinkwrap changes again? It seems like 37423a0 was an empty commit

@laumair laumair mentioned this pull request Apr 8, 2019
8 tasks
@laumair
Copy link
Contributor Author

laumair commented Apr 8, 2019

Opened a PR from different branch (#1274). Closing this one.

@laumair laumair closed this Apr 8, 2019
@laumair laumair deleted the feat/deeplink-migration branch April 8, 2019 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Mobile C - Shared E - Functional Epic - Relating to how a feature works L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants