Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Realm migrations setup improvements #1168

Merged
merged 12 commits into from
Apr 5, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Mar 5, 2019

Description

Fixes #1162

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Manually tested
  • Unit tests update

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@laumair laumair added the L - WIP Lifecycle - Work in Progress label Mar 5, 2019
@laumair laumair added C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this E - Functional Epic - Relating to how a feature works and removed L - WIP Lifecycle - Work in Progress labels Mar 6, 2019
@rajivshah3
Copy link
Member

Not sure if this is intentional or a bug:

If I start with a fresh simulator, run Trinity on the develop branch, and complete the onboarding, the Documents directory looks like this (run open $(xcrun simctl get_app_container booted com.iota.trinity data)/Documents to open it):
image

Then, I checkout feat/realm-migrations and run the app again. When I reach the login screen, it looks like this:
image

If I don't log in, but simply run the app again, it looks like trinity-1 is recreated:
image

@laumair
Copy link
Contributor Author

laumair commented Mar 14, 2019

If I don't log in, but simply run the app again, it looks like trinity-1 is recreated:

On which branch are you facing this?

@laumair
Copy link
Contributor Author

laumair commented Mar 14, 2019

This PR changes the storage path for realm but it should also remove the realm files on old paths.

@rajivshah3
Copy link
Member

On which branch are you facing this?

I think this one

@laumair
Copy link
Contributor Author

laumair commented Mar 17, 2019

@rajivshah3 I'll investigate.

@laumair laumair mentioned this pull request Apr 3, 2019
8 tasks
@cvarley100
Copy link
Contributor

@laumair Perhaps we should add some documentation on how to write a migration, and which variables need updating?

Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you reset the changes to the shrinkwrap? It looks like there weren't any changes to desktop/package.json so I don't think changes to the shrinkwrap are necessary

@laumair
Copy link
Contributor Author

laumair commented Apr 5, 2019

@rajivshah3

Looks good. Could you reset the changes to the shrinkwrap? It looks like there weren't any changes to desktop/package.json so I don't think changes to the shrinkwrap are necessary

Done

@laumair
Copy link
Contributor Author

laumair commented Apr 5, 2019

@cvarley100

Perhaps we should add some documentation on how to write a migration, and which variables need updating?

Good idea. I've created an issue. Will do a separate PR for this.

@laumair laumair merged commit eca370d into iotaledger:develop Apr 5, 2019
This was referenced Apr 16, 2019
@cvarley100 cvarley100 mentioned this pull request May 7, 2019
@laumair laumair deleted the feat/realm-migrations branch May 27, 2019 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Shared E - Functional Epic - Relating to how a feature works L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Realm migration setup
3 participants