This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Mobile/Android: Rebuild Entangled libs #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
added
T - Bug
rajivshah3
changed the title
rajivshah3
force-pushed
the
fix/android-21-22
branch
from
f8eba63
to
6861a61
Compare
rajivshah3
added
L - Need reviews
rihardsgravis
pushed a commit
that referenced
this pull request
May 7, 2019
* develop: Desktop: Settings and Onboarding fixes (#1457) Mobile/Android: Rebuild Entangled libs (#1464) Bump dart-sass from 1.19.0 to 1.20.1 in /src/desktop (#1469) Bump webpack-cli from 3.3.1 to 3.3.2 in /src/desktop (#1472) Bump electron from 3.1.8 to 3.1.9 in /src/desktop (#1475) Shared: [Snyk] Fix for 1 vulnerable dependencies (#1474) Mobile: [Snyk] Fix for 1 vulnerable dependencies (#1473) Bump eslint-plugin-react-native from 3.2.1 to 3.7.0 (#1389) Bump fastlane from 2.121.1 to 2.122.0 in /src/mobile/android (#1468) Bump fastlane from 2.121.1 to 2.122.0 in /src/mobile/ios (#1467) Bump eslint-plugin-react from 7.12.4 to 7.13.0 (#1460) Bump lint-staged from 8.1.5 to 8.1.6 (#1461)
rihardsgravis
pushed a commit
that referenced
this pull request
May 9, 2019
* develop: (23 commits) Bump snyk from 1.162.0 to 1.163.0 (#1491) New Crowdin translations (#1446) Desktop: Add migration explanation (#1445) Add issue template metadata [ci skip] (#1486) Update issue templates to newer version (#1484) Shared: Bump update versioning (#1478) Bump snyk from 1.161.1 to 1.162.0 in /src/shared (#1482) Bump snyk from 1.161.1 to 1.162.0 (#1481) Bump @babel/plugin-proposal-export-namespace-from in /src/shared (#1450) Desktop 0.5.0 Release (#1479) Desktop: Settings and Onboarding fixes (#1457) Mobile/Android: Rebuild Entangled libs (#1464) Bump dart-sass from 1.19.0 to 1.20.1 in /src/desktop (#1469) Bump webpack-cli from 3.3.1 to 3.3.2 in /src/desktop (#1472) Bump electron from 3.1.8 to 3.1.9 in /src/desktop (#1475) Shared: [Snyk] Fix for 1 vulnerable dependencies (#1474) Mobile: [Snyk] Fix for 1 vulnerable dependencies (#1473) Bump eslint-plugin-react-native from 3.2.1 to 3.7.0 (#1389) Bump fastlane from 2.121.1 to 2.122.0 in /src/mobile/android (#1468) Bump fastlane from 2.121.1 to 2.122.0 in /src/mobile/ios (#1467) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebuilds Entangled libraries with
-ldlflag to prevent crashes on Android 5.0/5.1 (API level 21/22)Related to bazelbuild/bazel#6959
Fixes #1463
Type of change
How Has This Been Tested?
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes