Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Shared: Fix CryptoCompare API calls #1595

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

rajivshah3
Copy link
Member

Description

On May 17, CryptoCompare changed the token ID for IOTA to MIOTA (it was previously IOT). This has caused some API calls to return incorrect results.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested on macOS (debug)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers P3 - Medium Priority - Normal priority labels May 23, 2019
@cvarley100 cvarley100 merged commit 88b0cb3 into develop May 24, 2019
@cvarley100
Copy link
Contributor

Nice!

@rajivshah3 rajivshah3 deleted the hotfix/cryptocompare branch May 24, 2019 12:31
rihardsgravis pushed a commit that referenced this pull request May 28, 2019
* develop: (21 commits)
  Bump snyk from 1.161.1 to 1.167.2 in /src/mobile (#1631)
  Bump jest from 24.0.0 to 24.8.0 in /src/mobile (#1614)
  Fix typo in contributor's name (#1629)
  Mobile: Fix "Duplicate module name" issue (#1628)
  Mobile: Update lockfile (#1627)
  Bump enzyme from 3.7.0 to 3.9.0 in /src/mobile (#1620)
  Bump @iota/core from 1.0.0-beta.11 to 1.0.0-beta.12 in /src/shared (#1452)
  Shared: Fix `getSelectedAccountMeta` selector (#1605)
  Bump react-native-timer from 1.3.4 to 1.3.6 in /src/mobile (#1618)
  Bump patch-package from 6.0.2 to 6.1.2 in /src/mobile (#1617)
  Bump @babel/preset-env from 7.4.4 to 7.4.5 in /src/desktop (#1572)
  Bump @babel/core from 7.4.4 to 7.4.5 in /src/desktop (#1571)
  Mobile: [Snyk] Fix for 1 vulnerable dependencies (#1202)
  Bump snyk from 1.167.0 to 1.167.2 (#1611)
  Bump eslint-plugin-import from 2.17.2 to 2.17.3 (#1610)
  Bump iota.lib.js from 0.5.1 to 0.5.2 in /src/desktop (#1599)
  Desktop: Update Ledger onboarding error handling (#1603)
  Desktop: Update desktop README (#1601)
  Bump snyk from 1.166.1 to 1.167.0 (#1600)
  Shared: Fix CryptoCompare API calls (#1595)
  ...

# Conflicts:
#	src/desktop/npm-shrinkwrap.json
@rihardsgravis rihardsgravis mentioned this pull request May 30, 2019
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers P3 - Medium Priority - Normal priority T - Bug Type - Bug: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants