This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Desktop: Fix Ledger onboarding error handling #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihardsgravis
added
T - Bug
rajivshah3
approved these changes
May 24, 2019
rihardsgravis
pushed a commit
that referenced
this pull request
May 28, 2019
* develop: (21 commits) Bump snyk from 1.161.1 to 1.167.2 in /src/mobile (#1631) Bump jest from 24.0.0 to 24.8.0 in /src/mobile (#1614) Fix typo in contributor's name (#1629) Mobile: Fix "Duplicate module name" issue (#1628) Mobile: Update lockfile (#1627) Bump enzyme from 3.7.0 to 3.9.0 in /src/mobile (#1620) Bump @iota/core from 1.0.0-beta.11 to 1.0.0-beta.12 in /src/shared (#1452) Shared: Fix `getSelectedAccountMeta` selector (#1605) Bump react-native-timer from 1.3.4 to 1.3.6 in /src/mobile (#1618) Bump patch-package from 6.0.2 to 6.1.2 in /src/mobile (#1617) Bump @babel/preset-env from 7.4.4 to 7.4.5 in /src/desktop (#1572) Bump @babel/core from 7.4.4 to 7.4.5 in /src/desktop (#1571) Mobile: [Snyk] Fix for 1 vulnerable dependencies (#1202) Bump snyk from 1.167.0 to 1.167.2 (#1611) Bump eslint-plugin-import from 2.17.2 to 2.17.3 (#1610) Bump iota.lib.js from 0.5.1 to 0.5.2 in /src/desktop (#1599) Desktop: Update Ledger onboarding error handling (#1603) Desktop: Update desktop README (#1601) Bump snyk from 1.166.1 to 1.167.0 (#1600) Shared: Fix CryptoCompare API calls (#1595) ... # Conflicts: # src/desktop/npm-shrinkwrap.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Desktop Ledger onboarding
setIndexwould keep the wallet on loading state forever if itself raises an error which does not include amessage.Type of change
How Has This Been Tested?
Tested on macOS and Linux Ubuntu
Checklist: