Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fix keyboard avoidance globally #767

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@cvarley100
Copy link
Member

commented Dec 10, 2018

Description

  • Fixes keyboard avoidance through KeyboardMonitor HOC

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Tested across Android and iOS

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes

cvarley100 added some commits Dec 10, 2018

@rajivshah3 rajivshah3 merged commit a62ef8b into develop Dec 10, 2018

8 of 9 checks passed

ci/bitrise/e1c71066b5c75521/pr Failed - trinity-mobile
Details
buildkite/trinity-desktop-prs Build #1385 passed (5 minutes, 36 seconds)
Details
buildkite/trinity-mobile-prs Build #1421 passed (6 minutes, 34 seconds)
Details
buildkite/trinity-shared-prs Build #409 passed (4 minutes, 44 seconds)
Details
security/snyk - package.json (IOTA Foundation) No new issues
Details
security/snyk - src/desktop/package.json (IOTA Foundation) No new issues
Details
security/snyk - src/mobile/android/app/build.gradle (IOTA Foundation) No manifest changes detected
security/snyk - src/mobile/package.json (IOTA Foundation) No new issues
Details
security/snyk - src/shared/package.json (IOTA Foundation) No new issues
Details

@rajivshah3 rajivshah3 deleted the bug/keyboard-avoidance branch Dec 10, 2018

rihardsgravis added a commit that referenced this pull request Dec 12, 2018

Merge branch 'develop' into feat/deskto-settings-view
* develop: (141 commits)
  New Crowdin translations [ci skip] (#769)
  Mobile: Fix minor bugs (#771)
  Assign account index to accounts in state (#715)
  Mobile: Fix failing tests (#770)
  Desktop: Add two-factor authorisation to Password modal (#764)
  Localization improvements (#718)
  Mobile: Fix keyboard avoidance globally (#767)
  Mobile: Handle error if permissions are denied on SeedVault import (#719)
  New Crowdin translations [ci skip] (#667)
  Desktop: Delete yarn.lock (#768)
  Update Seed write down view `Done` locale to `Back` (#765)
  Mobile: Minor refactor
  Update src/mobile/android/gradlew.bat
  Mobile: Minor code cleanup
  Fix unresolved conflict
  Localise string
  Update src/mobile/src/ui/views/wallet/DeleteAccount.js
  Update src/mobile/src/ui/components/TransferConfirmationModal.js
  Preserve order of themes via indexes in ThemeCustomisation component (#763)
  [Security] Bump lodash from 4.17.4 to 4.17.10 (#723)
  ...

# Conflicts:
#	src/desktop/src/ui/views/account/Addresses.js
#	src/desktop/src/ui/views/settings/Advanced.js
#	src/desktop/src/ui/views/settings/account/Seed.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.