Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Mobile: Fix keyboard avoidance globally #767

Merged
merged 2 commits into from Dec 10, 2018
Merged

Conversation

cvarley100
Copy link
Contributor

@cvarley100 cvarley100 commented Dec 10, 2018

Description

  • Fixes keyboard avoidance through KeyboardMonitor HOC

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Tested across Android and iOS

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes

@rajivshah3 rajivshah3 merged commit a62ef8b into develop Dec 10, 2018
@rajivshah3 rajivshah3 deleted the bug/keyboard-avoidance branch December 10, 2018 21:29
rihardsgravis pushed a commit that referenced this pull request Dec 12, 2018
* develop: (141 commits)
  New Crowdin translations [ci skip] (#769)
  Mobile: Fix minor bugs (#771)
  Assign account index to accounts in state (#715)
  Mobile: Fix failing tests (#770)
  Desktop: Add two-factor authorisation to Password modal (#764)
  Localization improvements (#718)
  Mobile: Fix keyboard avoidance globally (#767)
  Mobile: Handle error if permissions are denied on SeedVault import (#719)
  New Crowdin translations [ci skip] (#667)
  Desktop: Delete yarn.lock (#768)
  Update Seed write down view `Done` locale to `Back` (#765)
  Mobile: Minor refactor
  Update src/mobile/android/gradlew.bat
  Mobile: Minor code cleanup
  Fix unresolved conflict
  Localise string
  Update src/mobile/src/ui/views/wallet/DeleteAccount.js
  Update src/mobile/src/ui/components/TransferConfirmationModal.js
  Preserve order of themes via indexes in ThemeCustomisation component (#763)
  [Security] Bump lodash from 4.17.4 to 4.17.10 (#723)
  ...

# Conflicts:
#	src/desktop/src/ui/views/account/Addresses.js
#	src/desktop/src/ui/views/settings/Advanced.js
#	src/desktop/src/ui/views/settings/account/Seed.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants