This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Preserve order of themes via indexes in ThemeCustomisation component #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laumair
added
T - Bug
rajivshah3
approved these changes
Dec 10, 2018
rihardsgravis
pushed a commit
that referenced
this pull request
Dec 12, 2018
* develop: (141 commits) New Crowdin translations [ci skip] (#769) Mobile: Fix minor bugs (#771) Assign account index to accounts in state (#715) Mobile: Fix failing tests (#770) Desktop: Add two-factor authorisation to Password modal (#764) Localization improvements (#718) Mobile: Fix keyboard avoidance globally (#767) Mobile: Handle error if permissions are denied on SeedVault import (#719) New Crowdin translations [ci skip] (#667) Desktop: Delete yarn.lock (#768) Update Seed write down view `Done` locale to `Back` (#765) Mobile: Minor refactor Update src/mobile/android/gradlew.bat Mobile: Minor code cleanup Fix unresolved conflict Localise string Update src/mobile/src/ui/views/wallet/DeleteAccount.js Update src/mobile/src/ui/components/TransferConfirmationModal.js Preserve order of themes via indexes in ThemeCustomisation component (#763) [Security] Bump lodash from 4.17.4 to 4.17.10 (#723) ... # Conflicts: # src/desktop/src/ui/views/account/Addresses.js # src/desktop/src/ui/views/settings/Advanced.js # src/desktop/src/ui/views/settings/account/Seed.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to RN 0.57 has caused issue where
Object.keysno longer preserves the order of keys of an object. This has affected several areas including this.Type of change
How Has This Been Tested?
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodesshared: If applicable, I have verified that my changes are implemented correctly indesktopandmobile