Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prepublish commands to dasel v2 #1661

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

rajivshah3
Copy link
Member

Description of change

Breaking changes in dasel (used to manipulate the Cargo.toml for the Node.js bindings so they can be built from source) caused the publish process to fail, so it had to be reverted to a previous version (#1651). This PR updates the dasel commands so they work with v2 (they are now simpler as well). After the dasel commands are run, the Cargo.toml looks like this:

[dependencies.iota-wallet]
    features = ["mnemonic", "events", "ledger_nano", "storage", "stronghold", "message_interface", "participation"]
    git = "https://github.com/iotaledger/wallet.rs"
    rev = "some-git-rev"

This matches what is currently published

Links to any relevant issues

iotaledger/iota-sdk#96

Type of change

  • Chore

How the change has been tested

Tested commands locally:

cd bindings/nodejs
export GITHUB_SHA=some-git-rev
dasel put -f Cargo.toml '.dependencies.iota-wallet.rev' -v $GITHUB_SHA
dasel put -f Cargo.toml '.dependencies.iota-wallet.git' -v https://github.com/iotaledger/wallet.rs
dasel delete -f Cargo.toml '.dependencies.iota-wallet.path'
dasel delete -f Cargo.toml '.dependencies.iota-wallet.default-features'

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have checked that new and existing unit tests pass locally with my changes

@thibault-martinez thibault-martinez merged commit d861990 into develop Dec 9, 2022
@thibault-martinez thibault-martinez deleted the chore/dasel-v2 branch December 9, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants