add new ioctl alias remove command and test #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 167 167
Lines 13852 13852
=======================================
Hits 7828 7828
Misses 5020 5020
Partials 1004 1004Continue to review full report at Codecov.
|
CoderZhi
requested changes
Jan 23, 2020
| } | ||
| client.EXPECT().Config().Return(cfg).AnyTimes() | ||
| cmd := NewAliasRemove(client) | ||
| res, err := util.ExecuteCmd(cmd, "a") |
There was a problem hiding this comment.
incomplete unit test: how do you verify that the corresponding alias has been removed?
There was a problem hiding this comment.
@CoderZhi
supplementary test
…nto feature/add_new_cmd
CoderZhi
approved these changes
Jan 24, 2020
Comment on lines
+66
to
+68
| if err := ioutil.WriteFile(config.DefaultConfigFile, out, 0600); err != nil { | ||
| return output.NewError(output.WriteFileError, fmt.Sprintf(writeError, config.DefaultConfigFile), err) | ||
| } |
There was a problem hiding this comment.
it would better if we can move these lines into client
There was a problem hiding this comment.
@CoderZhi
Does it mean adding a new method on the client?
E.g:
type Client interface {
SaveConfig(cfg config.Config) error
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1771
@CoderZhi