Apply Two Layer Trie and Refactor WorkingSet #1892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
==========================================
+ Coverage 61.53% 61.57% +0.03%
==========================================
Files 164 164
Lines 13504 13462 -42
==========================================
- Hits 8310 8289 -21
+ Misses 4142 4129 -13
+ Partials 1052 1044 -8
Continue to review full report at Codecov.
|
CoderZhi
force-pushed
the
apply_two_layer_trie
branch
from
2871e2c
to
c6e4b49
Compare
yutongp
reviewed
Feb 20, 2020
| default: | ||
| return nil, err | ||
| } | ||
| dbForTrie, err := db.NewKVStoreForTrie(ArchiveTrieNamespace, dao) |
There was a problem hiding this comment.
so if the kvstore exist already, this NewKVStoreForTrie doesn't have any side effect?
Comment on lines
+278
to
+301
| getStateFunc: func(ns string, key []byte, s interface{}) error { | ||
| return readState(tlt, ns, key, s) | ||
| }, | ||
| putStateFunc: func(ns string, key []byte, s interface{}) error { | ||
| ss, err := state.Serialize(s) | ||
| if err != nil { | ||
| return errors.Wrapf(err, "failed to convert account %v to bytes", s) | ||
| } | ||
| flusher.KVStoreWithBuffer().MustPut(ns, key, ss) | ||
| nsHash := hash.Hash160b([]byte(ns)) | ||
|
|
||
| return tlt.Upsert(nsHash[:], key, ss) | ||
| }, | ||
| delStateFunc: func(ns string, key []byte) error { | ||
| flusher.KVStoreWithBuffer().MustDelete(ns, key) | ||
| nsHash := hash.Hash160b([]byte(ns)) | ||
|
|
||
| return tlt.Delete(nsHash[:], key) | ||
| }, | ||
| digestFunc: func() hash.Hash256 { | ||
| return hash.Hash256b(flusher.SerializeQueue()) | ||
| }, | ||
| finalizeFunc: func(h uint64) error { | ||
| if finalized { |
There was a problem hiding this comment.
imo define all these callback/closure is not as clear as defining methods on a given struct.
| @@ -28,6 +28,18 @@ import ( | |||
| "github.com/iotexproject/iotex-core/pkg/log" | |||
| ) | |||
|
|
|||
| func processOptions(opts ...protocol.StateOption) (bool, uint64, string, []byte, error) { | |||
There was a problem hiding this comment.
i think just return cfg, make this function simpler to read and use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1881